components/dom_distiller/content/browser/distiller_javascript_service_impl.cc - Issue 2883643002: Clean up ReaderMode OverlayPanel classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/distiller_javascript_service_impl.cc

Issue 2883643002: Clean up ReaderMode OverlayPanel classes (Closed)

Patch Set: remove extra enum Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java ('K') | « components/dom_distiller/content/browser/distiller_javascript_service_impl.h ('k') | components/dom_distiller/content/browser/distiller_ui_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/browser/distiller_javascript_service_impl.cc

diff --git a/components/dom_distiller/content/browser/distiller_javascript_service_impl.cc b/components/dom_distiller/content/browser/distiller_javascript_service_impl.cc

index 2dea5f1be2e3f5028ced02873134cf800a72ab9a..54244dcb89a5d186e0f7d788426cc15ec00eff4d 100644

--- a/components/dom_distiller/content/browser/distiller_javascript_service_impl.cc

+++ b/components/dom_distiller/content/browser/distiller_javascript_service_impl.cc

@@ -22,15 +22,6 @@ DistillerJavaScriptServiceImpl::DistillerJavaScriptServiceImpl(

DistillerJavaScriptServiceImpl::~DistillerJavaScriptServiceImpl() {}

-void DistillerJavaScriptServiceImpl::HandleDistillerClosePanelCall(

- bool animate) {

- base::RecordAction(base::UserMetricsAction("DomDistiller_ViewOriginal"));

- if (!distiller_ui_handle_) {

- return;

- }

- distiller_ui_handle_->ClosePanel(animate);

void DistillerJavaScriptServiceImpl::HandleDistillerOpenSettingsCall() {

if (!distiller_ui_handle_) {

return;