Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerDelegate.java

Issue 2883643002: Clean up ReaderMode OverlayPanel classes (Closed)
Patch Set: remove extra enum Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerDelegate.java
deleted file mode 100644
index 66d5cf4269b32bfe96343e6dcd8426e8873e9a23..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerDelegate.java
+++ /dev/null
@@ -1,55 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.dom_distiller;
-
-import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
-import org.chromium.content_public.browser.WebContents;
-
-/**
- * Delegate for the panel to call into the manager.
- */
-public interface ReaderModeManagerDelegate {
- /**
- * Load a URL in a new tab.
- * @param url The URL to load in the tab.
- */
- void createNewTab(String url);
-
- /**
- * Notify the manager that the panel was actually shown.
- */
- void onPanelShown();
-
- /**
- * Notify the manager that the panel has completely closed.
- */
- void onClosed(StateChangeReason reason);
-
- /**
- * Get the WebContents of the page that is being distilled.
- * @return The WebContents for the currently visible tab.
- */
- WebContents getBasePageWebContents();
-
- /**
- * Close the Reader Mode panel. This method wrap's the ReaderModePanel's close function and
- * checks for null.
- * @param reason The reason the panel is being closed.
- * @param animate If the panel should animate as it closes.
- */
- void closeReaderPanel(StateChangeReason reason, boolean animate);
-
- /**
- * @return The ChromeActivity that owns the manager.
- */
- ChromeActivity getChromeActivity();
-
- /**
- * Record the amount of time that a user spent in the Reader Mode panel.
- * @param timeInMs The amount of time spent in ms.
- */
- void recordTimeSpentInReader(long timeInMs);
-}

Powered by Google App Engine
This is Rietveld 408576698