Extract PerformanceLogger from AnalysisDriver.

Extract PerformanceLogger from AnalysisDriver.

I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a4fd5d814f15529b009c62db5b41dcd488b2800f

[Brian Wilkerson, 2017-05-12 21:16:10]

Seems like a 'performance' package might be a better place for this, but aside
from that and a couple of other comments, lgtm.

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:1: <?xml version="1.0"
encoding="UTF-8"?>
Please coordinate with Paul on this. He has a CL out that deletes all the iml
files, and I'd hate to see them creep back in.

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:70: import
'package:front_end/src/base/performace_logger.dart' as nd;
Does this really need to be prefixed? If so, does 'nd' mean something? If not,
could we choose an identifier that does?

[Paul Berry, 2017-05-12 21:22:34]

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:1: <?xml version="1.0"
encoding="UTF-8"?>
On 2017/05/12 21:16:09, Brian Wilkerson wrote:
> Please coordinate with Paul on this. He has a CL out that deletes all the iml
> files, and I'd hate to see them creep back in.

Go ahead and land your CL.  I want to give my CL at least an hour for review in
case someone raises an objection.  I'll make sure that when I land my CL it
really deletes the files.

[scheglov, 2017-05-12 21:27:55]

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2883633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:70: import
'package:front_end/src/base/performace_logger.dart' as nd;
On 2017/05/12 21:16:09, Brian Wilkerson wrote:
> Does this really need to be prefixed? If so, does 'nd' mean something? If not,
> could we choose an identifier that does?

"nd" means "new driver" :-)
I had to use it to avoid conflicts between AnalysisDriver classes.
We might try to get rid of it altogether.
Definitely can do this for PerformanceLogger.
Fixed.

[scheglov, 2017-05-12 21:27:56]

Description was changed from

==========
Extract PerformanceLogger from AnalysisDriver.

I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Extract PerformanceLogger from AnalysisDriver.

I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a4fd5d814f15529b009c62db5b41dcd488b2800f
==========

[scheglov, 2017-05-12 21:27:57]

Committed patchset #1 (id:1) manually as
a4fd5d814f15529b009c62db5b41dcd488b2800f (presubmit successful).