Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2883563002: Refactor UKM interface for mojo-ification (Closed)
Patch Set: Move interface to next CL Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 0449ba3981401daa5f6951978bd4ca4ff78ea0e6..2818c9d2c284028c7c6b36097d13fbf498a58ca6 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -18,9 +18,10 @@
#include "components/autofill/core/browser/field_types.h"
#include "components/autofill/core/common/autofill_pref_names.h"
#include "components/autofill/core/common/form_field_data.h"
+#include "components/ukm/public/ukm_recorder.h"
namespace ukm {
-class UkmService;
+class UkmRecorder;
} // namespace ukm
namespace internal {
@@ -624,7 +625,7 @@ class AutofillMetrics {
// Utility to log URL keyed form interaction events.
class FormInteractionsUkmLogger {
public:
- explicit FormInteractionsUkmLogger(ukm::UkmService* ukm_service);
+ explicit FormInteractionsUkmLogger(ukm::UkmRecorder* ukm_recorder);
const GURL& url() const { return url_; }
@@ -648,8 +649,8 @@ class AutofillMetrics {
int64_t MillisecondsSinceFormLoaded() const;
void GetNewSourceID();
- ukm::UkmService* ukm_service_; // Weak reference.
- int32_t source_id_ = -1;
+ ukm::UkmRecorder* ukm_recorder_; // Weak reference.
+ ukm::SourceId source_id_ = -1;
GURL url_;
base::TimeTicks form_loaded_timestamp_;
};
@@ -821,20 +822,20 @@ class AutofillMetrics {
// Logs the card upload decisions ukm for the specified |url|.
// |upload_decision_metrics| is a bitmask of |CardUploadDecisionMetric|.
- static void LogCardUploadDecisionsUkm(ukm::UkmService* ukm_service,
+ static void LogCardUploadDecisionsUkm(ukm::UkmRecorder* ukm_recorder,
const GURL& url,
int upload_decision_metrics);
// Logs the developer engagement ukm for the specified |url| and autofill
// fields in the form structure. |developer_engagement_metrics| is a bitmask
// of |AutofillMetrics::DeveloperEngagementMetric|.
- static void LogDeveloperEngagementUkm(ukm::UkmService* ukm_service,
+ static void LogDeveloperEngagementUkm(ukm::UkmRecorder* ukm_recorder,
const GURL& url,
int developer_engagement_metrics);
// Logs the the |ukm_entry_name| with the specified |url| and the specified
// |metrics|. Returns whether the ukm was sucessfully logged.
- static bool LogUkm(ukm::UkmService* ukm_service,
+ static bool LogUkm(ukm::UkmRecorder* ukm_recorder,
const GURL& url,
const std::string& ukm_entry_name,
const std::vector<std::pair<const char*, int>>& metrics);

Powered by Google App Engine
This is Rietveld 408576698