Refactor UKM interface for mojo-ification

components/translate/core/browser/translate_ranker_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_ranker_impl.h"
 
 #include <initializer_list>
 #include <memory>
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/task_scheduler/post_task.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/test/scoped_task_environment.h"
 #include "components/metrics/proto/translate_event.pb.h"
 #include "components/metrics/proto/ukm/source.pb.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/sync_preferences/testing_pref_service_syncable.h"
 #include "components/translate/core/browser/proto/ranker_model.pb.h"
 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
 #include "components/translate/core/browser/ranker_model.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "components/translate/core/browser/translate_prefs.h"
-#include "components/ukm/test_ukm_service.h"
+#include "components/ukm/test_ukm_recorder.h"
 #include "components/ukm/ukm_source.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
 
 using translate::kTranslateRankerEnforcement;
 using translate::kTranslateRankerQuery;
@@ skipping 31 matching lines @@
       int decline_count,
       int ignore_count);
 
   // The platform-specific name of the preferred language pref.
   static const char* const kPreferredLanguagePref;
 
   // Prefs.
   std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_;
   std::unique_ptr<translate::TranslatePrefs> translate_prefs_;
 
-  ukm::TestUkmService* GetTestUkmService() {
-    return ukm_service_test_harness_.test_ukm_service();
-  }
+  ukm::TestUkmRecorder* GetTestUkmRecorder() { return &test_ukm_recorder_; }
   metrics::TranslateEventProto tep1_ =
       CreateTranslateEvent("fr", "en", 1, 0, 3);
   metrics::TranslateEventProto tep2_ =
       CreateTranslateEvent("jp", "en", 2, 0, 3);
   metrics::TranslateEventProto tep3_ =
       CreateTranslateEvent("es", "de", 4, 5, 6);
 
  private:
-  ukm::UkmServiceTestingHarness ukm_service_test_harness_;
+  ukm::TestUkmRecorder test_ukm_recorder_;
 
   // Override the default URL fetcher to return custom responses for tests.
   net::TestURLFetcherFactory url_fetcher_factory_;
 
   // Used to initialize the translate download manager.
   scoped_refptr<net::TestURLRequestContextGetter> request_context_;
 
   // Sets up the task scheduling/task-runner environment for each test.
   base::test::ScopedTaskEnvironment scoped_task_environment_;
 
@@ skipping 74 matching lines @@
   country_weight["de"] = 0.07f;
   country_weight["ca"] = 0.08f;
   country_weight["cn"] = 0.09f;
 
   auto& locale_weight = *details->mutable_locale_weight();
   locale_weight["en-us"] = 0.10f;
   locale_weight["en-ca"] = 0.11f;
   locale_weight["zh-cn"] = 0.12f;  // Normalized to lowercase.
 
   auto impl = base::MakeUnique<TranslateRankerImpl>(base::FilePath(), GURL(),
-                                                    GetTestUkmService());
+                                                    GetTestUkmRecorder());
   impl->OnModelAvailable(std::move(model));
   base::RunLoop().RunUntilIdle();
   return impl;
 }
 
 // static
 double TranslateRankerImplTest::Sigmoid(double x) {
   return 1.0 / (1.0 + exp(-x));
 }
 
@@ skipping 158 matching lines @@
   ASSERT_EQ(0, flushed_events[0].event_type());
   ASSERT_EQ(tep2_.source_language(), flushed_events[1].source_language());
   ASSERT_EQ(1, flushed_events[1].event_type());
   ASSERT_EQ(tep3_.source_language(), flushed_events[2].source_language());
   ASSERT_EQ(2, flushed_events[2].event_type());
 
   // Check that the cache has been cleared.
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
 
-  ASSERT_EQ(2U, GetTestUkmService()->sources_count());
+  ASSERT_EQ(2U, GetTestUkmRecorder()->sources_count());
   EXPECT_EQ(
       url0.spec(),
-      GetTestUkmService()->GetSourceForUrl(url0.spec().c_str())->url().spec());
+      GetTestUkmRecorder()->GetSourceForUrl(url0.spec().c_str())->url().spec());
   EXPECT_EQ(
       url1.spec(),
-      GetTestUkmService()->GetSourceForUrl(url1.spec().c_str())->url().spec());
+      GetTestUkmRecorder()->GetSourceForUrl(url1.spec().c_str())->url().spec());
 }
 
 TEST_F(TranslateRankerImplTest, LoggingDisabledViaOverride) {
   std::unique_ptr<translate::TranslateRankerImpl> ranker =
       GetRankerForTest(0.0f);
   std::vector<metrics::TranslateEventProto> flushed_events;
 
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
 
@@ skipping 43 matching lines @@
   EXPECT_TRUE(ranker->ShouldOverrideDecision(2, GURL(), &tep));
 
   std::vector<metrics::TranslateEventProto> flushed_events;
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
   ASSERT_EQ(2, tep.decision_overrides_size());
   ASSERT_EQ(1, tep.decision_overrides(0));
   ASSERT_EQ(2, tep.decision_overrides(1));
   ASSERT_EQ(0, tep.event_type());
 }