Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2883563002: Refactor UKM interface for mojo-ification (Closed)
Patch Set: Move interface to next CL Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker_impl.h" 5 #include "components/translate/core/browser/translate_ranker_impl.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/files/file_util.h" 13 #include "base/files/file_util.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/metrics/histogram_macros.h" 15 #include "base/metrics/histogram_macros.h"
16 #include "base/metrics/metrics_hashes.h" 16 #include "base/metrics/metrics_hashes.h"
17 #include "base/profiler/scoped_tracker.h" 17 #include "base/profiler/scoped_tracker.h"
18 #include "base/strings/string_number_conversions.h" 18 #include "base/strings/string_number_conversions.h"
19 #include "base/strings/string_util.h" 19 #include "base/strings/string_util.h"
20 #include "base/task_runner.h" 20 #include "base/task_runner.h"
21 #include "base/threading/thread_task_runner_handle.h" 21 #include "base/threading/thread_task_runner_handle.h"
22 #include "components/metrics/proto/translate_event.pb.h" 22 #include "components/metrics/proto/translate_event.pb.h"
23 #include "components/translate/core/browser/proto/ranker_model.pb.h" 23 #include "components/translate/core/browser/proto/ranker_model.pb.h"
24 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" 24 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
25 #include "components/translate/core/browser/ranker_model.h" 25 #include "components/translate/core/browser/ranker_model.h"
26 #include "components/translate/core/browser/translate_download_manager.h" 26 #include "components/translate/core/browser/translate_download_manager.h"
27 #include "components/translate/core/browser/translate_prefs.h" 27 #include "components/translate/core/browser/translate_prefs.h"
28 #include "components/translate/core/browser/translate_url_fetcher.h" 28 #include "components/translate/core/browser/translate_url_fetcher.h"
29 #include "components/translate/core/common/translate_switches.h" 29 #include "components/translate/core/common/translate_switches.h"
30 #include "components/ukm/ukm_entry_builder.h" 30 #include "components/ukm/public/ukm_entry_builder.h"
31 #include "components/ukm/ukm_service.h" 31 #include "components/ukm/public/ukm_recorder.h"
32 #include "components/variations/variations_associated_data.h" 32 #include "components/variations/variations_associated_data.h"
33 #include "url/gurl.h" 33 #include "url/gurl.h"
34 34
35 namespace translate { 35 namespace translate {
36 36
37 namespace { 37 namespace {
38 38
39 using chrome_intelligence::RankerModel; 39 using chrome_intelligence::RankerModel;
40 using chrome_intelligence::RankerModelProto; 40 using chrome_intelligence::RankerModelProto;
41 using chrome_intelligence::TranslateRankerModel; 41 using chrome_intelligence::TranslateRankerModel;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 << "denied_count=" << denied_count << ", " 129 << "denied_count=" << denied_count << ", "
130 << "ignored_count=" << ignored_count << ", " 130 << "ignored_count=" << ignored_count << ", "
131 << "total_count=" << total_count << ", " 131 << "total_count=" << total_count << ", "
132 << "accept_ratio=" << accepted_ratio << ", " 132 << "accept_ratio=" << accepted_ratio << ", "
133 << "decline_ratio=" << denied_ratio << ", " 133 << "decline_ratio=" << denied_ratio << ", "
134 << "ignore_ratio=" << ignored_ratio; 134 << "ignore_ratio=" << ignored_ratio;
135 } 135 }
136 136
137 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path, 137 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
138 const GURL& model_url, 138 const GURL& model_url,
139 ukm::UkmService* ukm_service) 139 ukm::UkmRecorder* ukm_recorder)
140 : ukm_service_(ukm_service), 140 : ukm_recorder_(ukm_recorder),
141 is_logging_enabled_(true), 141 is_logging_enabled_(true),
142 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)), 142 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
143 is_enforcement_enabled_( 143 is_enforcement_enabled_(
144 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)), 144 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),
145 is_decision_override_enabled_(base::FeatureList::IsEnabled( 145 is_decision_override_enabled_(base::FeatureList::IsEnabled(
146 translate::kTranslateRankerDecisionOverride)), 146 translate::kTranslateRankerDecisionOverride)),
147 weak_ptr_factory_(this) { 147 weak_ptr_factory_(this) {
148 if (is_query_enabled_ || is_enforcement_enabled_ || 148 if (is_query_enabled_ || is_enforcement_enabled_ ||
149 is_decision_override_enabled_) { 149 is_decision_override_enabled_) {
150 model_loader_ = base::MakeUnique<RankerModelLoader>( 150 model_loader_ = base::MakeUnique<RankerModelLoader>(
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 std::vector<metrics::TranslateEventProto>* events) { 286 std::vector<metrics::TranslateEventProto>* events) {
287 DCHECK(sequence_checker_.CalledOnValidSequence()); 287 DCHECK(sequence_checker_.CalledOnValidSequence());
288 DVLOG(3) << "Flushing translate ranker events."; 288 DVLOG(3) << "Flushing translate ranker events.";
289 events->swap(event_cache_); 289 events->swap(event_cache_);
290 event_cache_.clear(); 290 event_cache_.clear();
291 } 291 }
292 292
293 void TranslateRankerImpl::SendEventToUKM( 293 void TranslateRankerImpl::SendEventToUKM(
294 const metrics::TranslateEventProto& event, 294 const metrics::TranslateEventProto& event,
295 const GURL& url) { 295 const GURL& url) {
296 if (!ukm_service_) { 296 if (!ukm_recorder_) {
297 DVLOG(3) << "No UKM service."; 297 DVLOG(3) << "No UKM service.";
298 return; 298 return;
299 } 299 }
300 DVLOG(3) << "Sending event for url: " << url.spec(); 300 DVLOG(3) << "Sending event for url: " << url.spec();
301 int32_t source_id = ukm_service_->GetNewSourceID(); 301 ukm::SourceId source_id = ukm_recorder_->GetNewSourceID();
302 ukm_service_->UpdateSourceURL(source_id, url); 302 ukm_recorder_->UpdateSourceURL(source_id, url);
303 std::unique_ptr<ukm::UkmEntryBuilder> builder = 303 std::unique_ptr<ukm::UkmEntryBuilder> builder =
304 ukm_service_->GetEntryBuilder(source_id, "Translate"); 304 ukm_recorder_->GetEntryBuilder(source_id, "Translate");
305 // The metrics added here should be kept in sync with the documented 305 // The metrics added here should be kept in sync with the documented
306 // metrics in tools/metrics/ukm/ukm.xml. 306 // metrics in tools/metrics/ukm/ukm.xml.
307 // TODO(hamelphi): Remove hashing functions once UKM accepts strings metrics. 307 // TODO(hamelphi): Remove hashing functions once UKM accepts strings metrics.
308 builder->AddMetric("SourceLanguage", 308 builder->AddMetric("SourceLanguage",
309 base::HashMetricName(event.source_language())); 309 base::HashMetricName(event.source_language()));
310 builder->AddMetric("TargetLanguage", 310 builder->AddMetric("TargetLanguage",
311 base::HashMetricName(event.target_language())); 311 base::HashMetricName(event.target_language()));
312 builder->AddMetric("Country", base::HashMetricName(event.country())); 312 builder->AddMetric("Country", base::HashMetricName(event.country()));
313 builder->AddMetric("AcceptCount", event.accept_count()); 313 builder->AddMetric("AcceptCount", event.accept_count());
314 builder->AddMetric("DeclineCount", event.decline_count()); 314 builder->AddMetric("DeclineCount", event.decline_count());
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 } 368 }
369 } 369 }
370 370
371 } // namespace translate 371 } // namespace translate
372 372
373 std::ostream& operator<<(std::ostream& stream, 373 std::ostream& operator<<(std::ostream& stream,
374 const translate::TranslateRankerFeatures& features) { 374 const translate::TranslateRankerFeatures& features) {
375 features.WriteTo(stream); 375 features.WriteTo(stream);
376 return stream; 376 return stream;
377 } 377 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698