Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 288353005: DevTools: Introduce virtual AndroidDeviceManager::Device::HttpQuery (Closed)

Created:
6 years, 7 months ago by Vladislav Kaznacheev
Modified:
6 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@deviceinfo2
Visibility:
Public.

Description

DevTools: Introduce virtual AndroidDeviceManager::Device::HttpQuery This is required for DeviceProvider implementations that are not capable of creating sockets. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271362

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M chrome/browser/devtools/device/android_device_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 2 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vladislav Kaznacheev
6 years, 7 months ago (2014-05-16 16:20:02 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-05-18 05:49:34 UTC) #2
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 7 months ago (2014-05-18 08:07:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/288353005/1
6 years, 7 months ago (2014-05-18 08:07:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-18 08:34:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-18 08:37:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/26235) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/32727)
6 years, 7 months ago (2014-05-18 08:37:21 UTC) #7
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 7 months ago (2014-05-19 06:54:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/288353005/20001
6 years, 7 months ago (2014-05-19 06:54:36 UTC) #9
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 7 months ago (2014-05-19 07:41:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/288353005/40001
6 years, 7 months ago (2014-05-19 07:41:19 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 11:39:00 UTC) #12
Message was sent while issue was closed.
Change committed as 271362

Powered by Google App Engine
This is Rietveld 408576698