Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 288353004: Only set /ARCH:IA32 on x86 platform (Closed)

Created:
6 years, 7 months ago by Will Harris
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Only set /ARCH:IA32 on x86 platform This eliminates compile warnings on x64 platform: cl : Command line warning D9002 : ignoring unknown option '/arch:IA32' BUG=374053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271031

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/chrome_installer.gypi View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Will Harris
6 years, 7 months ago (2014-05-16 03:19:34 UTC) #1
scottmg
lgtm https://codereview.chromium.org/288353004/diff/1/chrome/chrome_installer.gypi File chrome/chrome_installer.gypi (right): https://codereview.chromium.org/288353004/diff/1/chrome/chrome_installer.gypi#newcode357 chrome/chrome_installer.gypi:357: [ 'target_arch=="ia32"', { extra space after [
6 years, 7 months ago (2014-05-16 03:36:30 UTC) #2
Will Harris
https://codereview.chromium.org/288353004/diff/1/chrome/chrome_installer.gypi File chrome/chrome_installer.gypi (right): https://codereview.chromium.org/288353004/diff/1/chrome/chrome_installer.gypi#newcode357 chrome/chrome_installer.gypi:357: [ 'target_arch=="ia32"', { On 2014/05/16 03:36:30, scottmg wrote: > ...
6 years, 7 months ago (2014-05-16 03:45:26 UTC) #3
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 7 months ago (2014-05-16 03:45:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/288353004/20001
6 years, 7 months ago (2014-05-16 03:46:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 05:16:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 06:11:54 UTC) #7
commit-bot: I haz the power
Failed to apply patch for @master/chrome/chrome_installer.gypi: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 06:11:55 UTC) #8
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 7 months ago (2014-05-16 16:30:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/288353004/20001
6 years, 7 months ago (2014-05-16 16:30:34 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 16:31:49 UTC) #11
Message was sent while issue was closed.
Change committed as 271031

Powered by Google App Engine
This is Rietveld 408576698