Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 288353003: Componentize invalidator storage + preferences (Closed)

Created:
6 years, 7 months ago by rlarocque
Modified:
6 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, blundell, bartfab (slow)
Visibility:
Public.

Description

Componentize invalidator storage + preferences Moves the preferences related to the core parts of the invalidator into components/invalidaton/invalidation_prefs.{cc,h}. Moves the InvalidatorStorage into the component. Its only dependency on chrome/ was the preference definitions. TBR=pam BUG=336571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -244 lines) Patch
M chrome/browser/invalidation/invalidation_service_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/invalidation/invalidator_storage.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/invalidation/invalidator_storage.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M components/invalidation.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M components/invalidation/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/invalidation/invalidation_prefs.h View 1 chunk +7 lines, -4 lines 0 comments Download
A components/invalidation/invalidation_prefs.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A + components/invalidation/invalidator_storage.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/invalidation/invalidator_storage.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rlarocque
Here's the next step in invalidations componentization. Please review.
6 years, 7 months ago (2014-05-16 00:09:32 UTC) #1
pavely
lgtm
6 years, 7 months ago (2014-05-16 13:50:27 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 7 months ago (2014-05-16 17:20:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/288353003/1
6 years, 7 months ago (2014-05-16 17:20:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 20:13:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 20:17:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68209)
6 years, 7 months ago (2014-05-16 20:17:53 UTC) #7
rlarocque
TBR'ing pam for added dependency on components/pref_registry.
6 years, 7 months ago (2014-05-16 20:20:10 UTC) #8
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 7 months ago (2014-05-16 20:20:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/288353003/1
6 years, 7 months ago (2014-05-16 20:20:29 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 01:51:12 UTC) #11
Message was sent while issue was closed.
Change committed as 271145

Powered by Google App Engine
This is Rietveld 408576698