Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: components/sync_bookmarks/bookmark_change_processor.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_bookmarks/bookmark_change_processor.cc
diff --git a/components/sync_bookmarks/bookmark_change_processor.cc b/components/sync_bookmarks/bookmark_change_processor.cc
index 96d50b12215ba35fa52175d51c3ad4c06b168a5c..5394b5ad526354c021ab1c4bdf205f39339b2206 100644
--- a/components/sync_bookmarks/bookmark_change_processor.cc
+++ b/components/sync_bookmarks/bookmark_change_processor.cc
@@ -968,7 +968,8 @@ void BookmarkChangeProcessor::SetSyncNodeFavicon(
sync_node->GetBookmarkSpecifics());
updated_specifics.set_favicon(favicon_bytes->front(),
favicon_bytes->size());
- updated_specifics.set_icon_url(bookmark_node->icon_url().spec());
+ updated_specifics.set_icon_url(
+ bookmark_node->icon_url() ? bookmark_node->icon_url()->spec() : "");
sky 2017/05/12 20:00:13 "" -> std::string()
ssid 2017/05/25 00:27:27 Done.
sync_node->SetBookmarkSpecifics(updated_specifics);
}
}

Powered by Google App Engine
This is Rietveld 408576698