components/bookmarks/browser/bookmark_model.cc - Issue 2883523002: Reduce the memory usage of bookmarks storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_model.cc

diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc

index f9d58ceeafbcdef3d4b63d51ae60b472722c2180..689ef752d25792d6b3f3a625bdefcbce10d66ae5 100644

--- a/components/bookmarks/browser/bookmark_model.cc

+++ b/components/bookmarks/browser/bookmark_model.cc

@@ -482,7 +482,7 @@ void BookmarkModel::OnFaviconsChanged(const std::set<GURL>& page_urls,

base::AutoLock url_lock(url_lock_);

for (const BookmarkNode* node : nodes_ordered_by_url_set_) {

- if (icon_url == node->icon_url())

+ if (node->icon_url() && icon_url == *node->icon_url())

to_update.insert(node);

}