Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: components/sync_bookmarks/bookmark_change_processor.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)
Patch Set: MakeUnique Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/titled_url_node_sorter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_bookmarks/bookmark_change_processor.cc
diff --git a/components/sync_bookmarks/bookmark_change_processor.cc b/components/sync_bookmarks/bookmark_change_processor.cc
index 96d50b12215ba35fa52175d51c3ad4c06b168a5c..63930d1d69058581c8e83a302b015749ac44d4d5 100644
--- a/components/sync_bookmarks/bookmark_change_processor.cc
+++ b/components/sync_bookmarks/bookmark_change_processor.cc
@@ -968,7 +968,9 @@ void BookmarkChangeProcessor::SetSyncNodeFavicon(
sync_node->GetBookmarkSpecifics());
updated_specifics.set_favicon(favicon_bytes->front(),
favicon_bytes->size());
- updated_specifics.set_icon_url(bookmark_node->icon_url().spec());
+ updated_specifics.set_icon_url(bookmark_node->icon_url()
+ ? bookmark_node->icon_url()->spec()
+ : std::string());
sync_node->SetBookmarkSpecifics(updated_specifics);
}
}
« no previous file with comments | « components/bookmarks/browser/titled_url_node_sorter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698