components/bookmarks/browser/bookmark_node.cc - Issue 2883523002: Reduce the memory usage of bookmarks storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_node.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)

Patch Set: MakeUnique Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_node.cc

diff --git a/components/bookmarks/browser/bookmark_node.cc b/components/bookmarks/browser/bookmark_node.cc

index 8bc1c292318d75af9f35347e93249921be151068..1977fcb5efd34fe154625a94380ff8aa53fb20b6 100644

--- a/components/bookmarks/browser/bookmark_node.cc

+++ b/components/bookmarks/browser/bookmark_node.cc

@@ -123,7 +123,7 @@ void BookmarkNode::Initialize(int64_t id) {

}

void BookmarkNode::InvalidateFavicon() {

- icon_url_ = GURL();

+ icon_url_.reset();

favicon_ = gfx::Image();

favicon_type_ = favicon_base::INVALID_ICON;

favicon_state_ = INVALID_FAVICON;