components/sync_bookmarks/bookmark_change_processor.cc - Issue 2883523002: Reduce the memory usage of bookmarks storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_bookmarks/bookmark_change_processor.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)

Patch Set: Move to client. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_bookmarks/bookmark_change_processor.cc

diff --git a/components/sync_bookmarks/bookmark_change_processor.cc b/components/sync_bookmarks/bookmark_change_processor.cc

index 96d50b12215ba35fa52175d51c3ad4c06b168a5c..63930d1d69058581c8e83a302b015749ac44d4d5 100644

--- a/components/sync_bookmarks/bookmark_change_processor.cc

+++ b/components/sync_bookmarks/bookmark_change_processor.cc

@@ -968,7 +968,9 @@ void BookmarkChangeProcessor::SetSyncNodeFavicon(

sync_node->GetBookmarkSpecifics());

updated_specifics.set_favicon(favicon_bytes->front(),

favicon_bytes->size());

- updated_specifics.set_icon_url(bookmark_node->icon_url().spec());

+ updated_specifics.set_icon_url(bookmark_node->icon_url()

+ ? bookmark_node->icon_url()->spec()

+ : std::string());

sync_node->SetBookmarkSpecifics(updated_specifics);

}