Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: components/bookmarks/browser/bookmark_storage.cc

Issue 2883523002: Reduce the memory usage of bookmarks storage (Closed)
Patch Set: Move to client. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_storage.cc
diff --git a/components/bookmarks/browser/bookmark_storage.cc b/components/bookmarks/browser/bookmark_storage.cc
index d32a90c88061a8b082c770da656f63da4bdfc0a2..e72bd1e06b0ba6d3538a60e722b507cc086dd000 100644
--- a/components/bookmarks/browser/bookmark_storage.cc
+++ b/components/bookmarks/browser/bookmark_storage.cc
@@ -53,6 +53,7 @@ void AddBookmarksToIndex(BookmarkLoadDetails* details,
void LoadCallback(const base::FilePath& path,
const base::WeakPtr<BookmarkStorage>& storage,
+ const std::vector<std::string>& excluded_meta_keys,
std::unique_ptr<BookmarkLoadDetails> details,
base::SequencedTaskRunner* task_runner) {
bool load_index = false;
@@ -69,6 +70,8 @@ void LoadCallback(const base::FilePath& path,
// thread.
int64_t max_node_id = 0;
BookmarkCodec codec;
+ codec.set_excluded_meta_info_keys(excluded_meta_keys);
+
TimeTicks start_time = TimeTicks::Now();
codec.Decode(details->bb_node(), details->other_folder_node(),
details->mobile_folder_node(), &max_node_id, *root.get());
@@ -169,7 +172,8 @@ void BookmarkStorage::LoadBookmarks(
sequenced_task_runner_->PostTask(
FROM_HERE,
base::Bind(&LoadCallback, writer_.path(), weak_factory_.GetWeakPtr(),
- base::Passed(&details), base::RetainedRef(task_runner)));
+ model_->client()->ExecludedMetaKeys(), base::Passed(&details),
+ base::RetainedRef(task_runner)));
}
void BookmarkStorage::ScheduleSave() {

Powered by Google App Engine
This is Rietveld 408576698