Reduce the memory usage of bookmarks storage

components/bookmarks/browser/bookmark_codec.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_codec.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 415 matching lines @@
   }
 
   return true;
 }
 
 void BookmarkCodec::DecodeMetaInfoHelper(
     const base::DictionaryValue& dict,
     const std::string& prefix,
     BookmarkNode::MetaInfoMap* meta_info_map) {
   for (base::DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
+    bool is_excluded = false;
+    for (const auto& excluded : excluded_meta_info_keys_) {

[sky, 2017/05/31 21:29:14]

Sorry if I wasn't clear. I'm suggesting you harcode the list of bogus values
here.

[ssid, 2017/05/31 21:44:52]

No problem. fixed it. Made it a single string. if we want more in future we can
make it a list.

+      if (it.key().find(excluded) != std::string::npos)

[sky, 2017/05/31 21:29:13]

You don't want a find, you want a starts with, right?

[ssid, 2017/05/31 21:44:52]

Done.

+        is_excluded = true;
+    }
+    if (is_excluded)
+      continue;
+
     if (it.value().IsType(base::Value::Type::DICTIONARY)) {
       const base::DictionaryValue* subdict;
       it.value().GetAsDictionary(&subdict);
       DecodeMetaInfoHelper(*subdict, prefix + it.key() + ".", meta_info_map);
     } else if (it.value().IsType(base::Value::Type::STRING)) {
       it.value().GetAsString(&(*meta_info_map)[prefix + it.key()]);
     }
   }
 }
 
@@ skipping 46 matching lines @@
   base::MD5Init(&md5_context_);
 }
 
 void BookmarkCodec::FinalizeChecksum() {
   base::MD5Digest digest;
   base::MD5Final(&digest, &md5_context_);
   computed_checksum_ = base::MD5DigestToBase16(digest);
 }
 
 }  // namespace bookmarks