third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h - Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl (Closed)

Patch Set: Add DCHECK(), remove logic for other marker types, fix test case Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

index b0875049e277b63ab6660b5eb77050f3869afdcc..eb7e7e9ccfecf707479fd8f83cc0b9802d2fbd08 100644

--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

@@ -24,7 +24,7 @@ class CORE_EXPORT TextMatchMarkerListImpl final : public DocumentMarkerList {

void Add(DocumentMarker*) final;

void Clear() final;

- const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() const final;

+ const HeapVector<Member<DocumentMarker>>& GetMarkers() const final;

bool MoveMarkers(int length, DocumentMarkerList* dst_list) final;

bool RemoveMarkers(unsigned start_offset, int length) final;

@@ -34,7 +34,7 @@ class CORE_EXPORT TextMatchMarkerListImpl final : public DocumentMarkerList {

DECLARE_VIRTUAL_TRACE();

private:

- HeapVector<Member<RenderedDocumentMarker>> markers_;

+ HeapVector<Member<DocumentMarker>> markers_;

DISALLOW_COPY_AND_ASSIGN(TextMatchMarkerListImpl);

};