Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(128)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/ads_observer/docwrite_provisional_frame.html
Issue
2883433002
:
[PageLoadMetrics] Handle case where navigation aborts (Closed)
Patch Set: Back to PS3
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h
chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc
chrome/test/BUILD.gn
chrome/test/data/ads_observer/docwrite_provisional_frame.html
chrome/test/data/ads_observer/pixel.png
chrome/test/data/ads_observer/pixel2.png
chrome/test/data/ads_observer/pixel3.png
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
chrome/test/data/ads_observer/pixel.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<iframe id="slow_frame" name="google_ads_iframe" src="/slow?100"></iframe>
3
4
<script>
5
window.addEventListener('message', function(e) {
6
domAutomationController.setAutomationId(0);
7
window.domAutomationController.send(e.data);
8
});
9
10
// slow takes 100 seconds to load, plenty of time to overwrite the
11
// provisional load.
12
let iframe = document.getElementById("slow_frame");
13
let doc = iframe.contentDocument;
14
15
doc.open();
16
doc.write("<html>Rewritten. <img src=pixel.png> <img src=pixel2.png> <img src= pixel3.png onload='parent.postMessage("loaded", "*");'></htm l>");
17
doc.close();
18
</script>
19
20
</html>
OLD
NEW
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
chrome/test/data/ads_observer/pixel.png »
('j') |
no next file with comments »
Issue 2883433002: [PageLoadMetrics] Handle case where navigation aborts (Closed)
Created 3 years, 7 months ago by jkarlin
Modified 3 years, 7 months ago
Reviewers: Bryan McQuade, Charlie Harrison
Base URL:
Comments: 2
This is Rietveld
408576698