sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart - Issue 288343014: dart2dart: Test cases for better code coverage in dart_tree rewritings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart

Issue 288343014: dart2dart: Test cases for better code coverage in dart_tree rewritings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart ('k') | tests/language/if_flatten1_test.dart » ('j') | tests/language/if_flatten1_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart

index 4d932214eb2e46c822221bff96818a3a3502c0f5..3a1c894340e7bf8afb50b2d78461fd5240ec25e3 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart

@@ -1353,7 +1353,7 @@ class LogicalRewriter extends Visitor<Statement, Expression> {

putInBooleanContext(node.elseExpression));

}

// x ? false : y ==> !x && y (if y is known to be a boolean)

- if (isBooleanValued(node.elseExpression) && isTrue(node.thenExpression)) {

+ if (isBooleanValued(node.elseExpression) && isFalse(node.thenExpression)) {

return new LogicalOperator.and(

makeCondition(node.condition, false, liftNots: false),

putInBooleanContext(node.elseExpression));