Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2883363002: Support tear-off completions for named params (in constructors) (flutter-intellij#836) (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support tear-off completions for named params (in constructors) (flutter-intellij#836) R=danrubel@google.com Fixes: https://github.com/flutter/flutter-intellij/issues/836 Committed: https://github.com/dart-lang/sdk/commit/aa491e7133cd9ff6db1766b35f0751b9b3a4a137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 2 chunks +20 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 3 chunks +121 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
3 years, 7 months ago (2017-05-16 18:05:10 UTC) #2
danrubel
Nice! LGTM
3 years, 7 months ago (2017-05-16 18:12:51 UTC) #3
pquitslund
3 years, 7 months ago (2017-05-16 20:40:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa491e7133cd9ff6db1766b35f0751b9b3a4a137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698