Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2883343002: Disable type erasure during strong mode tests. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -47 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_basic.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_basic.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart.strong.expect View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_function_parameter_type.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_function_parameter_type2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_function_return_type.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_instantiation.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_method_type.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_inference_error.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_inference_error.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_named.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_positional.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_positional2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_required.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_return_of_statement_lambda.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_return_of_statement_lambda.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method.dart.strong.expect View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method_identifier_sequence.dart.strong.expect View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_implicit_type_param.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-16 16:43:21 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-16 16:46:41 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 6a48f79ba37022873346bfd532388abc76a10104 (presubmit successful).
3 years, 7 months ago (2017-05-16 16:47:29 UTC) #5
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-17 17:29:28 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698