Use ViewStack to convert card upload request CVC experiment to 2-step flow

chrome/browser/ui/views/autofill/save_card_bubble_views.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
 
 #include <stddef.h>
 #include <memory>
 
 #include "base/strings/utf_string_conversions.h"
@@ skipping 36 matching lines @@
   }
   return label;
 }
 
 }  // namespace
 
 SaveCardBubbleViews::SaveCardBubbleViews(views::View* anchor_view,
                                          content::WebContents* web_contents,
                                          SaveCardBubbleController* controller)
     : LocationBarBubbleDelegateView(anchor_view, web_contents),
-      controller_(controller),
-      cvc_textfield_(nullptr),
-      learn_more_link_(nullptr) {
+      controller_(controller) {
   DCHECK(controller);
   views::BubbleDialogDelegateView::CreateBubble(this);
   chrome::RecordDialogCreation(chrome::DialogIdentifier::SAVE_CARD);
 }
 
 SaveCardBubbleViews::~SaveCardBubbleViews() {}
 
 void SaveCardBubbleViews::Show(DisplayReason reason) {
   ShowForReason(reason);
 }
@@ skipping 21 matching lines @@
       new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
 
   // Add a StyledLabel for each line of the legal message.
   for (const LegalMessageLine& line : controller_->GetLegalMessageLines())
     view->AddChildView(CreateLegalMessageLineLabel(line, this).release());
 
   return view;
 }
 
 bool SaveCardBubbleViews::Accept() {
+  // If upload save and more info is needed, push the next view onto the stack.

[csashi, 2017/05/18 17:42:25]

s/upload save and/user accepted upload but/

Move comment to inside if?

[Jared Saul, 2017/05/18 18:03:07]

Done.

+  if (controller_->ShouldRequestCvcFromUser() && view_stack_->size() == 1) {

[csashi, 2017/05/18 17:42:25]

DCHECK_LE(view_stack_->size(), 1)?
When can we be here if a view_stack_ size != 1?

[Jared Saul, 2017/05/18 18:03:07]

1) Done.
2) If missing CVC but on the second step of the bubble where CVC is being
entered.  The button that is clicked doesn't change.

[csashi, 2017/05/18 19:29:48]

For (2). If stack_size() > 1, should we
DCHECK(conroller_->ShouldRequestCvcFromUser());

[Jared Saul, 2017/05/18 19:51:36]

Added check for <= 2 stack size at all times, as well as a check for "must be
stack size 1 or ShouldRequestCvcFromUser()"

+    view_stack_->Push(CreateRequestCvcView(), /*animate=*/true);
+    // Disable the Save button until a valid CVC is entered:
+    GetDialogClientView()->UpdateDialogButtons();
+    // Resize the bubble if it's grown larger:
+    SizeToContents();
+    return false;

[csashi, 2017/05/18 17:42:25]

Do you need to update the documentation for Accept now? You are returning false
in some cases.

[Jared Saul, 2017/05/18 18:03:07]

Hmm, I don't think so.  The current documentation says "This function should
return true if the window can be closed after it returns, or false if it must
remain open." which seems sufficient.

+  }
+  // Otherwise, close the bubble as normal.
   if (controller_)
     controller_->OnSaveButton(cvc_textfield_ ? cvc_textfield_->text()
                                              : base::string16());
   return true;
 }
 
 bool SaveCardBubbleViews::Cancel() {
   if (controller_)
     controller_->OnCancelButton();
   return true;
@@ skipping 63 matching lines @@
       return;
     }
   }
 
   // |range| was not found.
   NOTREACHED();
 }
 
 // Create view containing everything except for the footnote.
 std::unique_ptr<views::View> SaveCardBubbleViews::CreateMainContentView() {
   std::unique_ptr<View> view(new View());

[csashi, 2017/05/18 17:42:25]

MakeUnique?

[Jared Saul, 2017/05/18 18:03:07]

Done.

+  view->set_background(views::Background::CreateSolidBackground(SK_ColorWHITE));
   view->SetLayoutManager(
       new views::BoxLayout(views::BoxLayout::kVertical, 0, 0,
                            views::kUnrelatedControlVerticalSpacing));
 
   // Add the card type icon, last four digits and expiration date.
   views::View* description_view = new views::View();
   description_view->SetLayoutManager(new views::BoxLayout(
       views::BoxLayout::kHorizontal, 0, 0, views::kRelatedButtonHSpacing));
   view->AddChildView(description_view);
 
   const CreditCard& card = controller_->GetCard();
   views::ImageView* card_type_icon = new views::ImageView();
   card_type_icon->SetImage(
       ResourceBundle::GetSharedInstance()
           .GetImageNamed(CreditCard::IconResourceId(card.network()))
           .AsImageSkia());
   card_type_icon->SetTooltipText(card.NetworkForDisplay());
   card_type_icon->SetBorder(
       views::CreateSolidBorder(1, SkColorSetA(SK_ColorBLACK, 10)));
   description_view->AddChildView(card_type_icon);
 
   description_view->AddChildView(new views::Label(
       base::string16(kMidlineEllipsis) + card.LastFourDigits()));
   description_view->AddChildView(
       new views::Label(card.AbbreviatedExpirationDateForDisplay()));
 
-  // Optionally add CVC request field if CVC was missing.
-  if (controller_->ShouldRequestCvcFromUser())
-    view->AddChildView(CreateRequestCvcView().release());
-
   // Optionally add label that will contain an explanation for upload.
   base::string16 explanation = controller_->GetExplanatoryMessage();
   if (!explanation.empty()) {
     views::Label* explanation_label = new views::Label(explanation);
     explanation_label->SetMultiLine(true);
     explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     view->AddChildView(explanation_label);
   }
 
   return view;
 }
 
 std::unique_ptr<views::View> SaveCardBubbleViews::CreateRequestCvcView() {

[csashi, 2017/05/18 17:42:25]

Do you want to rename this function? We are returning the 'overall' view now.

[Jared Saul, 2017/05/18 18:03:07]

I feel the name is still applicable as it's doing the same thing, but I had to
wrap the horizontal view in a vertical view or it had weird effects.  I'll
rename the variables to make it clearer.

+  std::unique_ptr<View> overall_view = base::MakeUnique<views::View>();
+  overall_view->set_background(
+      views::Background::CreateSolidBackground(SK_ColorWHITE));

[csashi, 2017/05/18 17:42:25]

Do you need this? Does the stack not inherit from the background from the view
on top of the stack?

[Jared Saul, 2017/05/18 18:03:07]

Without it, it doesn't cover up the item below it on the stack and you can see
through to the previous layer.

+  overall_view->SetLayoutManager(
+      new views::BoxLayout(views::BoxLayout::kVertical, 0, 0,
+                           views::kUnrelatedControlVerticalSpacing));
   std::unique_ptr<View> request_cvc_view = base::MakeUnique<views::View>();
+  request_cvc_view->set_background(
+      views::Background::CreateSolidBackground(SK_ColorWHITE));
   request_cvc_view->SetLayoutManager(new views::BoxLayout(
       views::BoxLayout::kHorizontal, 0, 0, views::kRelatedButtonHSpacing));
 
   DCHECK(!cvc_textfield_);
   cvc_textfield_ = CreateCvcTextfield();
   cvc_textfield_->set_controller(this);
   request_cvc_view->AddChildView(cvc_textfield_);
 
   views::ImageView* cvc_image = new views::ImageView();
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   cvc_image->SetImage(
       rb.GetImageSkiaNamed(controller_->GetCvcImageResourceId()));
   request_cvc_view->AddChildView(cvc_image);
 
   request_cvc_view->AddChildView(new views::Label(
       l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_CARD_PROMPT_ENTER_CVC)));
-  return request_cvc_view;
+
+  overall_view->AddChildView(request_cvc_view.release());
+  return overall_view;
 }
 
 bool SaveCardBubbleViews::IsDialogButtonEnabled(ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_CANCEL)
     return true;
 
   DCHECK_EQ(ui::DIALOG_BUTTON_OK, button);
   return !cvc_textfield_ ||
          controller_->InputCvcIsValid(cvc_textfield_->text());
 }
 
 void SaveCardBubbleViews::ContentsChanged(views::Textfield* sender,
                                           const base::string16& new_contents) {
   DCHECK_EQ(cvc_textfield_, sender);
   GetDialogClientView()->UpdateDialogButtons();
 }
 
 void SaveCardBubbleViews::Init() {
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
-  AddChildView(CreateMainContentView().release());
+  view_stack_ = base::MakeUnique<ViewStack>();
+  view_stack_->set_owned_by_client();  // Required else it'll be deleted twice.
+  view_stack_->Push(CreateMainContentView(), /*animate=*/false);
+  AddChildView(view_stack_.get());
 }
 
 }  // namespace autofill