Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

Issue 2883273003: Move the user interaction policy for FirstMeaningfulPaint UMA into renderer (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
index 9bafef2920a248d482ab09dacaf7d6cc53ad3424..5735ba3fb046f247266b53618cc4d584991bce4f 100644
--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
@@ -45,11 +45,14 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
int contents_height_before_layout,
int contents_height_after_layout,
int visible_height);
+ void NotifyInputEvent();
void NotifyPaint();
void CheckNetworkStable();
DECLARE_TRACE();
+ enum HadUserInput { kNoUserInput, kHadUserInput, kHadUserInputEnumMax };
+
private:
friend class FirstMeaningfulPaintDetectorTest;
@@ -66,6 +69,9 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
void ReportHistograms();
bool next_paint_is_meaningful_ = false;
+ HadUserInput had_user_input_ = kNoUserInput;
+ HadUserInput had_user_input_before_provisional_first_meaningful_paint_ =
+ kNoUserInput;
Member<PaintTiming> paint_timing_;
double provisional_first_meaningful_paint_ = 0.0;

Powered by Google App Engine
This is Rietveld 408576698