third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h - Issue 2883273003: Move the user interaction policy for FirstMeaningfulPaint UMA into renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

Issue 2883273003: Move the user interaction policy for FirstMeaningfulPaint UMA into renderer (Closed)

Patch Set: crash fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintTiming.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

index 9bafef2920a248d482ab09dacaf7d6cc53ad3424..fd8eeedc613a74d73267fddb4aa5067da804ee7b 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

@@ -45,6 +45,7 @@ class CORE_EXPORT FirstMeaningfulPaintDetector

int contents_height_before_layout,

int contents_height_after_layout,

int visible_height);

+ void NotifyInputEvent();

void NotifyPaint();

void CheckNetworkStable();

@@ -66,6 +67,8 @@ class CORE_EXPORT FirstMeaningfulPaintDetector

void ReportHistograms();

bool next_paint_is_meaningful_ = false;

+ bool had_user_input_ = false;

+ bool had_user_input_before_provisional_first_meaningful_paint_ = false;

Member<PaintTiming> paint_timing_;

double provisional_first_meaningful_paint_ = 0.0;