Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2883273003: Move the user interaction policy for FirstMeaningfulPaint UMA into renderer (Closed)
Patch Set: add testcase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index bcee81a879992156b747d4411ccd9e6f19542cc3..c7c04864ca5ec29959430f39a315f43af3f4147e 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -707,35 +707,3 @@ TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaint) {
internal::kHistogramFirstMeaningfulPaintStatus,
internal::FIRST_MEANINGFUL_PAINT_RECORDED, 1);
}
-
-TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaintAfterInteraction) {
- page_load_metrics::mojom::PageLoadTiming timing;
- page_load_metrics::InitPageLoadTimingForTest(&timing);
- timing.navigation_start = base::Time::FromDoubleT(1);
- timing.parse_timing->parse_start = base::TimeDelta::FromMilliseconds(5);
- timing.paint_timing->first_paint = base::TimeDelta::FromMilliseconds(10);
- PopulateRequiredTimingFields(&timing);
-
- NavigateAndCommit(GURL(kDefaultTestUrl));
- SimulateTimingUpdate(timing);
-
- blink::WebMouseEvent mouse_event(blink::WebInputEvent::kMouseDown,
- blink::WebInputEvent::kNoModifiers,
- blink::WebInputEvent::kTimeStampForTesting);
- SimulateInputEvent(mouse_event);
-
- timing.paint_timing->first_meaningful_paint =
- base::TimeDelta::FromMilliseconds(1000);
- PopulateRequiredTimingFields(&timing);
- SimulateTimingUpdate(timing);
-
- NavigateAndCommit(GURL(kDefaultTestUrl2));
-
- histogram_tester().ExpectTotalCount(
- internal::kHistogramFirstMeaningfulPaint, 0);
- histogram_tester().ExpectTotalCount(
- internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
- histogram_tester().ExpectBucketCount(
- internal::kHistogramFirstMeaningfulPaintStatus,
- internal::FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP, 1);
-}

Powered by Google App Engine
This is Rietveld 408576698