Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2883273003: Move the user interaction policy for FirstMeaningfulPaint UMA into renderer (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 5 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h" 8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
10 #include "chrome/test/base/testing_browser_process.h" 10 #include "chrome/test/base/testing_browser_process.h"
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 NavigateAndCommit(GURL(kDefaultTestUrl2)); 703 NavigateAndCommit(GURL(kDefaultTestUrl2));
704 704
705 histogram_tester().ExpectTotalCount( 705 histogram_tester().ExpectTotalCount(
706 internal::kHistogramFirstMeaningfulPaint, 1); 706 internal::kHistogramFirstMeaningfulPaint, 1);
707 histogram_tester().ExpectTotalCount( 707 histogram_tester().ExpectTotalCount(
708 internal::kHistogramParseStartToFirstMeaningfulPaint, 1); 708 internal::kHistogramParseStartToFirstMeaningfulPaint, 1);
709 histogram_tester().ExpectBucketCount( 709 histogram_tester().ExpectBucketCount(
710 internal::kHistogramFirstMeaningfulPaintStatus, 710 internal::kHistogramFirstMeaningfulPaintStatus,
711 internal::FIRST_MEANINGFUL_PAINT_RECORDED, 1); 711 internal::FIRST_MEANINGFUL_PAINT_RECORDED, 1);
712 } 712 }
713
714 TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaintAfterInteraction) {
715 page_load_metrics::mojom::PageLoadTiming timing;
716 page_load_metrics::InitPageLoadTimingForTest(&timing);
717 timing.navigation_start = base::Time::FromDoubleT(1);
718 timing.parse_timing->parse_start = base::TimeDelta::FromMilliseconds(5);
719 timing.paint_timing->first_paint = base::TimeDelta::FromMilliseconds(10);
720 PopulateRequiredTimingFields(&timing);
721
722 NavigateAndCommit(GURL(kDefaultTestUrl));
723 SimulateTimingUpdate(timing);
724
725 blink::WebMouseEvent mouse_event(blink::WebInputEvent::kMouseDown,
726 blink::WebInputEvent::kNoModifiers,
727 blink::WebInputEvent::kTimeStampForTesting);
728 SimulateInputEvent(mouse_event);
729
730 timing.paint_timing->first_meaningful_paint =
731 base::TimeDelta::FromMilliseconds(1000);
732 PopulateRequiredTimingFields(&timing);
733 SimulateTimingUpdate(timing);
734
735 NavigateAndCommit(GURL(kDefaultTestUrl2));
736
737 histogram_tester().ExpectTotalCount(
738 internal::kHistogramFirstMeaningfulPaint, 0);
739 histogram_tester().ExpectTotalCount(
740 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
741 histogram_tester().ExpectBucketCount(
742 internal::kHistogramFirstMeaningfulPaintStatus,
743 internal::FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP, 1);
744 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698