HTML Imports: Get rid of needsProcessOrStop() from dom/custom/

Source/core/html/imports/HTMLImportChild.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 188 matching lines @@
 }
 
 void HTMLImportChild::shareLoader(HTMLImportChild* loader)
 {
     ASSERT(!m_loader);
     m_loader = loader->m_loader;
     m_loader->addImport(this);
     stateWillChange();
 }
 
+bool HTMLImportChild::isWaitingForCustomElementMicrotaskSteps() const
+{
+    if (m_loader->microtaskQueue()->isEmpty())
+        return false;
+
+    size_t ignorableStepCount = 0;
+    for (HTMLImport* i = firstChild(); i; i = i->next()) {
+        HTMLImportChild* child = toHTMLImportChild(i);
+        if (child->hasMicrotaskStep() && !child->isSync())
+            ignorableStepCount++;
+    }
+
+    return ignorableStepCount < m_loader->microtaskQueue()->size();

[dominicc (has gone to gerrit), 2014/05/23 00:29:25]

Wrote a huge comment about this, but let me try and simplify:

The localization is good.

Checking the sizes is kind of implicit, so let's try to think of something
better; I have some ideas but I need to know more.

When would a non-sync import's Custom Element Microtask Import Step show up in
the parent import's CEMT queue? Why?

+}
+
 bool HTMLImportChild::isDone() const
 {
-    return m_loader && m_loader->isDone() && !m_loader->microtaskQueue()->needsProcessOrStop() && !m_customElementMicrotaskStep;
+    return m_loader && m_loader->isDone() && !isWaitingForCustomElementMicrotaskSteps() && !m_customElementMicrotaskStep;
 }
 
 bool HTMLImportChild::loaderHasError() const
 {
     return m_loader && m_loader->hasError();
 }
 
 
 void HTMLImportChild::setClient(HTMLImportChildClient* client)
 {
@@ skipping 39 matching lines @@
     fprintf(stderr, " loader=%p first=%d, step=%p sync=%s url=%s",
         m_loader,
         isFirst,
         m_customElementMicrotaskStep.get(),
         isSync() ? "Y" : "N",
         url().string().utf8().data());
 }
 #endif
 
 } // namespace WebCore