ui: Fix the path of DIR_TEST_DATA key.

ui: Fix the path of DIR_TEST_DATA key.

In the beginning there was an app/ directory, which is what ui/ is
today. This was back in 2011.

Ben started moving the pieces of app/ into ui/ in
commit f676780687464428e340d008a0d1ca13d9944628 - r70743

Looks like we forgot to update this when we moved the code test/data
directory.

BUG=None
TEST=ui_unittests --gtest_filter=DataPackTest.*
R=tony@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270940

[tfarina, 2014-05-15 23:41:03]

Hi Tony, could you review this to me?

Thanks,

[tony, 2014-05-15 23:58:26]

LGTM with the following fixed.

https://codereview.chromium.org/288323003/diff/1/ui/base/ui_base_paths.cc
File ui/base/ui_base_paths.cc (right):

https://codereview.chromium.org/288323003/diff/1/ui/base/ui_base_paths.cc#new...
ui/base/ui_base_paths.cc:45: case DIR_TEST_DATA:
I would name this UI_DIR_TEST_DATA to make it clear which test dir we're talking
about.

[tfarina, 2014-05-16 01:16:57]

https://codereview.chromium.org/288323003/diff/1/ui/base/ui_base_paths.cc
File ui/base/ui_base_paths.cc (right):

https://codereview.chromium.org/288323003/diff/1/ui/base/ui_base_paths.cc#new...
ui/base/ui_base_paths.cc:45: case DIR_TEST_DATA:
On 2014/05/15 23:58:26, tony wrote:
> I would name this UI_DIR_TEST_DATA to make it clear which test dir we're
talking
> about.

Done.

[tfarina, 2014-05-16 03:11:36]

Tony I removed the ASSERT_TRUE and added a TODO instead to investigate.

/b/build/slave/ios_dbg_simulator/build/src/ui/base/resource/data_pack_unittest.cc:102:
Failure
Value of: PathService::Get(UI_DIR_TEST_DATA, &data_path)
  Actual: false
Expected: true

So my conclusion is that the old code was also failing but silently, since there
was no check.

[tfarina, 2014-05-16 03:12:00]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-16 03:13:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/288323003/40001

[commit-bot: I haz the power, 2014-05-16 05:25:09]

Change committed as 270940