Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 288323002: Make marked merge base invalid when the upstream changes. (Closed)

Created:
6 years, 7 months ago by iannucci
Modified:
6 years, 7 months ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Make marked merge base invalid when the upstream changes. This should let the base marker transparently work with plain-old-git tools which was the idea in the first place. Specifically `git branch -u` without a corresponding rebase. R=agable@chromium.org BUG=373977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271112

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -15 lines) Patch
M git_common.py View 4 chunks +11 lines, -2 lines 0 comments Download
M git_map.py View 1 chunk +1 line, -0 lines 1 comment Download
M git_mark_merge_base.py View 2 chunks +2 lines, -2 lines 0 comments Download
M git_reparent_branch.py View 3 chunks +4 lines, -2 lines 1 comment Download
M tests/git_common_test.py View 8 chunks +33 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
iannucci
6 years, 7 months ago (2014-05-15 22:10:40 UTC) #1
iannucci
https://codereview.chromium.org/288323002/diff/1/git_map.py File git_map.py (right): https://codereview.chromium.org/288323002/diff/1/git_map.py#newcode53 git_map.py:53: merge_base_map = {b: v for b, v in merge_base_map.iteritems() ...
6 years, 7 months ago (2014-05-15 22:20:17 UTC) #2
agable
LGTM
6 years, 7 months ago (2014-05-16 21:59:08 UTC) #3
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-16 22:19:44 UTC) #4
iannucci
6 years, 7 months ago (2014-05-16 22:31:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r271112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698