Add tests for FeaturePolicy integration with RenderFrameHost

content/common/feature_policy/feature_policy.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/feature_policy/feature_policy.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 
@@ skipping 128 matching lines @@
     const ParsedFeaturePolicyHeader& parsed_header) {
   DCHECK(whitelists_.empty());
   for (const ParsedFeaturePolicyDeclaration& parsed_declaration :
        parsed_header) {
     blink::WebFeaturePolicyFeature feature = parsed_declaration.feature;
     DCHECK(feature != blink::WebFeaturePolicyFeature::kNotFound);
     whitelists_[feature] = WhitelistFromDeclaration(parsed_declaration);
   }
 }
 
+bool FeaturePolicy::HasSetHeaderPolicy() const {
+  return !whitelists_.empty();

[alexmos, 2017/05/17 22:48:49]

Can you set an empty policy in the header, one that would keep whitelists_
empty?  If so, it seems like this would return the wrong thing here.

[raymes, 2017/05/21 22:11:20]

Ahh good catch. I've removed this for now, as right now we don't have the state
anywhere to check this. If you felt comfortable about it, I could add a bool
which was set to true in RenderFrameHostImpl::OnDidSetFeaturePolicyHeader but it
would only be for DCHECKing.

[alexmos, 2017/05/22 23:05:47]

I'm fine leaving it out until there's a more substantial need. :)

+}
+
 FeaturePolicy::FeaturePolicy(url::Origin origin,
                              const FeatureList& feature_list)
     : origin_(origin), feature_list_(feature_list) {}
 
 FeaturePolicy::FeaturePolicy(url::Origin origin)
     : origin_(origin), feature_list_(GetDefaultFeatureList()) {}
 
 FeaturePolicy::~FeaturePolicy() {}
 
 // static
@@ skipping 76 matching lines @@
                            {blink::WebFeaturePolicyFeature::kSyncXHR,
                             FeaturePolicy::FeatureDefault::EnableForAll},
                            {blink::WebFeaturePolicyFeature::kWebRTC,
                             FeaturePolicy::FeatureDefault::EnableForAll},
                            {blink::WebFeaturePolicyFeature::kUsb,
                             FeaturePolicy::FeatureDefault::EnableForSelf}}));
   return default_feature_list;
 }
 
 }  // namespace content