Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

Issue 2883163002: Un-insanify first-letter handling in TextIterator (to some degree) (Closed)
Patch Set: Tue May 16 16:31:00 PDT 2017 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.h
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
index ec92d405e2f2857fc4a5548666bfacbb3dc29005..86efdcbbdd633f36861edb6af42683d5e653a1ff 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
@@ -142,13 +142,6 @@ class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm {
bool ShouldHandleFirstLetter(const LayoutText&) const;
bool ShouldProceedToRemainingText() const;
void ProceedToRemainingText();
- // Helper function during initialization. Returns true if the start position
- // is in a text node with first-letter, in which case it also sets up related
- // parameters. Returns false otherwise.
- bool PrepareForFirstLetterInitialization();
- bool HasNotAdvancedToStartPosition();
- int AdjustedStartForFirstLetter(const Node&, const LayoutText&, int, int);
- int AdjustedStartForRemainingText(const Node&, const LayoutText&, int, int);
void SpliceBuffer(UChar,
Node* text_node,
Node* offset_base_node,
@@ -259,11 +252,6 @@ class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm {
// |SelectionToStringWithShadowTree|, we should not use other purpose.
bool handle_shadow_root_;
- // Used for adjusting the initialization and the output when the start
- // container is a text node with :first-letter.
- int first_letter_start_offset_;
- int remaining_text_start_offset_;
-
// Contains state of emitted text.
TextIteratorTextState text_state_;
};

Powered by Google App Engine
This is Rietveld 408576698