third_party/WebKit/LayoutTests/accessibility/first-letter-text-transform-causes-crash-expected.txt - Issue 2883163002: Un-insanify first-letter handling in TextIterator (to some degree)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/first-letter-text-transform-causes-crash-expected.txt

Issue 2883163002: Un-insanify first-letter handling in TextIterator (to some degree) (Closed)

Patch Set: Rebaseline Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Dt	1 Dt

2 End of test	2 End of test

3	3

4 First letter text transform causes assert and bad type cast. This can cause a cr ash.	4 First letter text transform causes assert and bad type cast. This can cause a cr ash.

5	5

6 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	6 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

7	7

8	8

9 AXRole: AXWebArea	9 AXRole: AXWebArea

10 AXRole: AXDescriptionListTerm	10 AXRole: AXDescriptionListTerm

11 AXRole: AXStaticText "Dt"	11 AXRole: AXStaticText "Dt"

12 AXRole: AXInlineTextBox "Dt"	12 AXRole: AXInlineTextBox "D"
Xiaocheng 2017/05/16 03:50:06 dmazzoni@: Is it that AX is depending on incorrect dmazzoni@: Is it that AX is depending on incorrect behavior of TextIterator? When with first-letter, AXInlineTextBox seems to hold only the text box of first-letter. Before this patch, TextIterator cannot correctly stop inside first-letter, so it emits "Dt" even if the given range is just "D" (the first-letter). With the patch, TextIterator only emits "D" when the given range is the first-letter. However, it makes the AX tree dump look wrong... dmazzoni 2017/05/16 16:01:15 Happy to have this fixed! Show quoted text On 2017/05/16 03:50:06, Xiaocheng wrote: > dmazzoni@: Is it that AX is depending on incorrect behavior of TextIterator? > > When with first-letter, AXInlineTextBox seems to hold only the text box of > first-letter. Before this patch, TextIterator cannot correctly stop inside > first-letter, so it emits "Dt" even if the given range is just "D" (the > first-letter). > > With the patch, TextIterator only emits "D" when the given range is the > first-letter. However, it makes the AX tree dump look wrong... Happy to have this fixed!
13 AXRole: AXParagraph	13 AXRole: AXParagraph

14 AXRole: AXStaticText "End of test"	14 AXRole: AXStaticText "End of test"

15 PASS successfullyParsed is true	15 PASS successfullyParsed is true

16	16

17 TEST COMPLETE	17 TEST COMPLETE

18	18

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt » ('j') | no next file with comments »