Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 288313012: Revert of Repurpose views+content example into a generic multiprocess views runtime (Closed)

Created:
6 years, 7 months ago by alph
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Visibility:
Public.

Description

Revert of Repurpose views+content example into a generic multiprocess views runtime (https://codereview.chromium.org/284113011/) Reason for revert: Broke Blink runhooks step http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/12039 Original issue's description: > Repurpose views+content example into a generic multiprocess views runtime > > This is to facilitate the addition of an app launcher example/demo app, > separate from the browser, and to assist testing of the out-of-process > compositor on mac. > > The change splits out from the current views_examples_with_content_exe > target a new views_content_client target placed in > ui/views_content_client. views_examples_with_content_exe is updated to > use it. > > This will allow the app launcher to have its own example app, while > reusing the logic to set up the multiprocess runtime environment for > using views and content. > > Follow-up patches for the views_content_client runtime will: isolate > aura dependencies, introduce the gpu_process UI compositor, and > implement the runtime environment for mac. > > BUG=365977 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272476 TBR=ben@chromium.org,tapted@chromium.org NOTREECHECKS=true NOTRY=true BUG=365977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -612 lines) Patch
M ui/views/examples/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A ui/views/examples/content_client/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_browser_main_parts.h View 1 chunk +61 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_content_browser_client.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_content_browser_client.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_main.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_main_delegate.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ui/views/examples/content_client/examples_main_delegate.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M ui/views/examples/examples.gyp View 3 chunks +55 lines, -2 lines 0 comments Download
D ui/views/examples/examples_with_content_main_exe.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/views_content_client/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/views_content_client/README.chromium View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/views_content_client/views_content_browser_client.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/views_content_client/views_content_browser_client.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/views_content_client/views_content_client.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ui/views_content_client/views_content_client.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/views_content_client/views_content_client.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/views_content_client/views_content_client_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/views_content_client/views_content_client_main_parts.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ui/views_content_client/views_content_client_main_parts.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D ui/views_content_client/views_content_main_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/views_content_client/views_content_main_delegate.cc View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alph
Created Revert of Repurpose views+content example into a generic multiprocess views runtime
6 years, 7 months ago (2014-05-23 11:15:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/288313012/1
6 years, 7 months ago (2014-05-23 11:15:59 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:17:07 UTC) #3
Message was sent while issue was closed.
Change committed as 272489

Powered by Google App Engine
This is Rietveld 408576698