Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: net/quic/quic_unacked_packet_map.cc

Issue 288313003: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: implemented rch's comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_unacked_packet_map.cc
diff --git a/net/quic/quic_unacked_packet_map.cc b/net/quic/quic_unacked_packet_map.cc
index a21d4a5c541bdc7494a947fcfb176cec6bdb29dd..a8fe3b5eb44145f766d6cbda0b92a510e3a4ca2d 100644
--- a/net/quic/quic_unacked_packet_map.cc
+++ b/net/quic/quic_unacked_packet_map.cc
@@ -166,11 +166,11 @@ void QuicUnackedPacketMap::MaybeRemoveRetransmittableFrames(
}
// static
-bool QuicUnackedPacketMap::IsSentAndNotPending(
+bool QuicUnackedPacketMap::IsForRttOnly(
const TransmissionInfo& transmission_info) {
return !transmission_info.pending &&
- transmission_info.sent_time != QuicTime::Zero() &&
- transmission_info.bytes_sent == 0;
+ transmission_info.retransmittable_frames == NULL &&
+ transmission_info.all_transmissions->size() == 1;
}
bool QuicUnackedPacketMap::IsUnacked(
@@ -198,13 +198,7 @@ bool QuicUnackedPacketMap::HasUnackedPackets() const {
}
bool QuicUnackedPacketMap::HasPendingPackets() const {
- for (UnackedPacketMap::const_reverse_iterator it =
- unacked_packets_.rbegin(); it != unacked_packets_.rend(); ++it) {
- if (it->second.pending) {
- return true;
- }
- }
- return false;
+ return bytes_in_flight_ > 0;
}
const TransmissionInfo& QuicUnackedPacketMap::GetTransmissionInfo(
@@ -271,17 +265,6 @@ bool QuicUnackedPacketMap::HasUnackedRetransmittableFrames() const {
return false;
}
-size_t QuicUnackedPacketMap::GetNumRetransmittablePackets() const {
- size_t num_unacked_packets = 0;
- for (UnackedPacketMap::const_iterator it = unacked_packets_.begin();
- it != unacked_packets_.end(); ++it) {
- if (it->second.retransmittable_frames != NULL) {
- ++num_unacked_packets;
- }
- }
- return num_unacked_packets;
-}
-
QuicPacketSequenceNumber
QuicUnackedPacketMap::GetLeastUnackedSentPacket() const {
if (unacked_packets_.empty()) {

Powered by Google App Engine
This is Rietveld 408576698