Tweaks to ViewManager:

mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "mojo/public/cpp/shell/service.h"
 #include "mojo/public/interfaces/shell/shell.mojom.h"
@@ skipping 288 matching lines @@
       connected_(false),
       connection_id_(0),
       next_id_(1),
       next_server_change_id_(0),
       sync_factory_(this),
       init_loop_(NULL) {
   ConnectTo(ViewManagerPrivate(view_manager_).shell(), "mojo:mojo_view_manager",
             &service_);
   service_->SetClient(this);
 
-  AllocationScope scope;
-  service_->GetNodeTree(
-      1,
-      base::Bind(&ViewManagerSynchronizer::OnRootTreeReceived,
-                 base::Unretained(this)));
-
+  // Start a runloop. This loop is quit when the server tells us about the
+  // connection (OnConnectionEstablished()).
   base::RunLoop loop;
   init_loop_ = &loop;
   init_loop_->Run();
   init_loop_ = NULL;
 }
 
 ViewManagerSynchronizer::~ViewManagerSynchronizer() {
   Sync();
 }
 
@@ skipping 65 matching lines @@
   pending_transactions_.push_back(
       new SetActiveViewTransaction(node_id, view_id, this));
   Sync();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ViewManagerSynchronizer, IViewManagerClient implementation:
 
 void ViewManagerSynchronizer::OnConnectionEstablished(
     TransportConnectionId connection_id,
-    TransportChangeId next_server_change_id) {
+    TransportChangeId next_server_change_id,
+    const mojo::Array<INode>& nodes) {
   connected_ = true;
   connection_id_ = connection_id;
   next_server_change_id_ = next_server_change_id;
+
+  ViewManagerPrivate private_manager(view_manager_);
+  std::vector<ViewTreeNode*> parents;
+  ViewTreeNode* root = NULL;
+  ViewTreeNode* last_node = NULL;
+  for (size_t i = 0; i < nodes.size(); ++i) {
+    if (last_node && nodes[i].parent_id() == last_node->id()) {
+      parents.push_back(last_node);
+    } else if (!parents.empty()) {
+      while (parents.back()->id() != nodes[i].parent_id())
+        parents.pop_back();
+    }
+    ViewTreeNode* node =
+        AddNodeToViewManager(view_manager_,
+                             !parents.empty() ? parents.back() : NULL,
+                             nodes[i].node_id(),
+                             nodes[i].view_id());
+    if (!last_node)
+      root = node;
+    last_node = node;
+  }
+  private_manager.set_root(root);
+  if (init_loop_)
+    init_loop_->Quit();
+
   Sync();
 }
 
+void ViewManagerSynchronizer::OnServerChangeIdAdvanced(
+    uint32_t next_server_change_id) {
+  next_server_change_id_ = next_server_change_id;
+}
+
 void ViewManagerSynchronizer::OnNodeHierarchyChanged(
     uint32_t node_id,
     uint32_t new_parent_id,
     uint32_t old_parent_id,
-    TransportChangeId server_change_id) {
+    TransportChangeId server_change_id,
+    const mojo::Array<INode>& nodes) {
+  // TODO: deal with |nodes|.
   next_server_change_id_ = server_change_id + 1;
 
   ViewTreeNode* new_parent =
       view_manager_->tree()->GetChildById(new_parent_id);
   ViewTreeNode* old_parent =
       view_manager_->tree()->GetChildById(old_parent_id);
   ViewTreeNode* node = NULL;
   if (old_parent) {
     // Existing node, mapped in this connection's tree.
     // TODO(beng): verify this is actually true.
@@ skipping 64 matching lines @@
       (*it)->Commit();
   }
 }
 
 void ViewManagerSynchronizer::RemoveFromPendingQueue(
     ViewManagerTransaction* transaction) {
   DCHECK_EQ(transaction, pending_transactions_.front());
   pending_transactions_.erase(pending_transactions_.begin());
 }
 
-void ViewManagerSynchronizer::OnRootTreeReceived(
-    const Array<INode>& nodes) {
-  ViewManagerPrivate private_manager(view_manager_);
-  std::vector<ViewTreeNode*> parents;
-  ViewTreeNode* root = NULL;
-  ViewTreeNode* last_node = NULL;
-  for (size_t i = 0; i < nodes.size(); ++i) {
-    if (last_node && nodes[i].parent_id() == last_node->id()) {
-      parents.push_back(last_node);
-    } else if (!parents.empty()) {
-      while (parents.back()->id() != nodes[i].parent_id())
-        parents.pop_back();
-    }
-    ViewTreeNode* node =
-        AddNodeToViewManager(view_manager_,
-                             !parents.empty() ? parents.back() : NULL,
-                             nodes[i].node_id(),
-                             nodes[i].view_id());
-    if (!last_node)
-      root = node;
-    last_node = node;
-  }
-  private_manager.set_root(root);
-  if (init_loop_)
-    init_loop_->Quit();
-}
-
 }  // namespace view_manager
 }  // namespace mojo