Quantify instability according to the stability instrumentation

components/browser_watcher/postmortem_report_collector.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Following an unclean shutdown, a stability report can be collected and
 // submitted for upload to a reporter.
 
 #ifndef COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_
 #define COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_
 
@@ skipping 72 matching lines @@
 
   // Virtual for unittesting.
   virtual std::vector<base::FilePath> GetDebugStateFilePaths(
       const base::FilePath& debug_info_dir,
       const base::FilePath::StringType& debug_file_pattern,
       const std::set<base::FilePath>& excluded_debug_files);
 
   CollectionStatus CollectAndSubmitOneReport(
       const crashpad::UUID& client_id,
       const base::FilePath& file,
-      crashpad::CrashReportDatabase* report_database);
+      crashpad::CrashReportDatabase* report_database,

[Sigurður Ásgeirsson, 2017/05/18 12:45:03]

A single session can only contribute a single count - right? 
So maybe the contract here is better with a bool out parameter, signifying
whether THIS session was unclean.
That way the success checking logic also comes to a single point, and doesn't
need a whole lot of commenting?

[manzagop (departed), 2017/05/18 14:52:12]

Done.

+      int* unclean_system_cnt);
 
   virtual CollectionStatus CollectOneReport(
       const base::FilePath& stability_file,
       StabilityReport* report);
 
   void SetReporterDetails(StabilityReport* report) const;
 
   void RecordSystemShutdownState(StabilityReport* report) const;
 
   virtual bool WriteReportToMinidump(StabilityReport* report,
                                      const crashpad::UUID& client_id,
                                      const crashpad::UUID& report_id,
                                      base::PlatformFile minidump_file);
 
   std::string product_name_;
   std::string version_number_;
   std::string channel_name_;
 
   SystemSessionAnalyzer* system_session_analyzer_;  // Not owned.
 
   DISALLOW_COPY_AND_ASSIGN(PostmortemReportCollector);
 };
 
 }  // namespace browser_watcher
 
 #endif  // COMPONENTS_BROWSER_WATCHER_POSTMORTEM_REPORT_COLLECTOR_H_