third_party/WebKit/LayoutTests/paint/pagination/composited-paginated-inline.html - Issue 2883083004: Only adjust composited pagination position to account for lines offset of inlines.

Side by Side Diff: third_party/WebKit/LayoutTests/paint/pagination/composited-paginated-inline.html

Issue 2883083004: Only adjust composited pagination position to account for lines offset of inlines. (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>
	chrishtr 2017/05/16 00:00:29 This test was previously broken, because the non-c This test was previously broken, because the non-composited -expected.html file duplicated the regular one. I had to make it a pixel test to avoid subpixel rendering issues. trchen 2017/05/16 23:26:47 lol. I think it is possible to keep it a ref-test Show quoted text On 2017/05/16 00:00:29, chrishtr wrote: > This test was previously broken, because the non-composited -expected.html file > duplicated the > regular one. I had to make it a pixel test to avoid subpixel rendering issues. lol. I think it is possible to keep it a ref-test by adding a solid background color. Or an alternative is to keep will-change:transform on the expectation, but use absolute position (instead of columns) to layout the test text. chrishtr 2017/05/17 02:00:14 I tried to make it a ref test, but failed (tried b Show quoted text On 2017/05/16 at 23:26:47, trchen wrote: > On 2017/05/16 00:00:29, chrishtr wrote: > > This test was previously broken, because the non-composited -expected.html file > > duplicated the > > regular one. I had to make it a pixel test to avoid subpixel rendering issues. > > lol. I think it is possible to keep it a ref-test by adding a solid background color. Or an alternative is to keep will-change:transform on the expectation, but use absolute position (instead of columns) to layout the test text. I tried to make it a ref test, but failed (tried both of your suggestions). Ok to commit as is? trchen 2017/05/17 20:48:49 Hmm weird. Adding solid background worked for me, Show quoted text On 2017/05/17 02:00:14, chrishtr wrote: > On 2017/05/16 at 23:26:47, trchen wrote: > > On 2017/05/16 00:00:29, chrishtr wrote: > > > This test was previously broken, because the non-composited -expected.html > file > > > duplicated the > > > regular one. I had to make it a pixel test to avoid subpixel rendering > issues. > > > > lol. I think it is possible to keep it a ref-test by adding a solid background > color. Or an alternative is to keep will-change:transform on the expectation, > but use absolute position (instead of columns) to layout the test text. > > I tried to make it a ref test, but failed (tried both of your suggestions). > Ok to commit as is? Hmm weird. Adding solid background worked for me, but I got 1 pixel difference with will-change:transform;position:absolute too. I uploaded my working ref test here for you to cherrypick: https://codereview.chromium.org/2892593004 lgtm either way. You make the call. :)
	3 <script src="../../resources/testharnessreport.js"></script>

2 <!-- Passes if the text shows up in the top of the second column -->	4 <!-- Passes if the text shows up in the top of the second column -->

3 <div style="columns:2; column-fill:auto; width:100px; height:40px; line-height:2 0px">	5 <div style="columns:2; column-fill:auto; width:100px; height:40px; line-height:2 0px">

4 <br><br>	6 <br><br>

5 <div style='display: inline; position: relative; will-change: transform'>tex t</div>	7 <div style='display: inline; position: relative; will-change: transform'>tex t</div>

6 </div>	8 </div>

	9 <script>

	10 test(function() {});

	11 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/pagination/composited-paginated-inline-expected.html » ('j') | no next file with comments »