Introduce Visible Networks Tracker.

chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..06f40625c624be200923bdf147c7cc477e090d5a
--- /dev/null
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java
@@ -0,0 +1,230 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.omnibox.geo;
+
+import static org.junit.Assert.assertEquals;
+
+import android.content.Context;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.annotation.Config;
+import org.robolectric.annotation.Implementation;
+import org.robolectric.annotation.Implements;
+
+import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleCell;
+import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleWifi;
+import org.chromium.chrome.browser.omnibox.geo.VisibleNetworksTrackerTest.ShadowPlatformNetworksManager;
+import org.chromium.testing.local.CustomShadowAsyncTask;
+import org.chromium.testing.local.LocalRobolectricTestRunner;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * Robolectric tests for {@link VisibleNetworksTracker}.
+ */
+@RunWith(LocalRobolectricTestRunner.class)
+@Config(manifest = Config.NONE,
+        shadows = {ShadowPlatformNetworksManager.class, CustomShadowAsyncTask.class})
+public class VisibleNetworksTrackerTest {
+    private static final VisibleWifi VISIBLE_WIFI_1 =
+            VisibleWifi.create("ssid1", "11:11:11:11:11:11", 1, 10L);
+    private static final VisibleWifi VISIBLE_WIFI_2 =
+            VisibleWifi.create("ssid2", "11:11:11:11:11:12", 2, 20L);
+    private static final VisibleCell VISIBLE_CELL_1 =
+            VisibleCell.builder(VisibleCell.GSM_RADIO_TYPE)
+                    .setCellId(30)
+                    .setLocationAreaCode(31)
+                    .setMobileCountryCode(32)
+                    .setMobileNetworkCode(33)
+                    .setTimestamp(30L)
+                    .build();
+    private static final VisibleCell VISIBLE_CELL_2 =
+            VisibleCell.builder(VisibleCell.CDMA_RADIO_TYPE)
+                    .setCellId(40)
+                    .setLocationAreaCode(41)
+                    .setMobileCountryCode(42)
+                    .setMobileNetworkCode(43)
+                    .setTimestamp(40L)
+                    .build();
+
+    private static final VisibleNetworks FIRST_ALL_VISIBLE_NETWORKS =
+            VisibleNetworks.create(VISIBLE_WIFI_1, VISIBLE_CELL_1,
+                    new HashSet<VisibleWifi>(Arrays.asList(VISIBLE_WIFI_1, VISIBLE_WIFI_2)),
+                    new HashSet<VisibleCell>(Arrays.asList(VISIBLE_CELL_1, VISIBLE_CELL_2)));
+    private static final VisibleNetworks SECOND_ALL_VISIBLE_NETWORKS = VisibleNetworks.create(
+            VISIBLE_WIFI_2, VISIBLE_CELL_2, new HashSet<VisibleWifi>(Arrays.asList(VISIBLE_WIFI_1)),
+            new HashSet<VisibleCell>(Arrays.asList(VISIBLE_CELL_1)));
+    private static final VisibleNetworks FIRST_ONLY_CONNECTED_NETWORKS =
+            VisibleNetworks.create(VISIBLE_WIFI_1, VISIBLE_CELL_1, null, null);
+    private static final VisibleNetworks SECOND_ONLY_CONNECTED_NETWORKS =
+            VisibleNetworks.create(VISIBLE_WIFI_2, VISIBLE_CELL_2, null, null);
+
+    private static long sCurrentTime;
+    private static final long CURRENT_TIME_MS = 90000000L;
+    private static final int AGE_THRESHOLD = 5 * 60 * 1000; // 5 min

[Ted C, 2017/05/18 02:13:33]

i would just make the other constant protected

[lbargu, 2017/05/18 14:15:29]

Done.

+    private static final long ELAPSED_UNDER_THRESHOLD_TIME_MS = AGE_THRESHOLD - 1000L;
+    private static final long ELAPSED_OVER_THRESHOLD_TIME_MS = AGE_THRESHOLD + 1000L;
+
+    @Mock
+    private static Context sContext;
+
+    @Before
+    public void setUp() {
+        MockitoAnnotations.initMocks(this);
+        sCurrentTime = CURRENT_TIME_MS;
+        VisibleNetworksTracker.sTimeProvider = new VisibleNetworksTracker.TimeProvider() {

[Ted C, 2017/05/18 02:13:33]

instead of introducing the TimeProvider, can you instead use ShadowSystemClock
for your use case?

[lbargu, 2017/05/18 14:15:29]

Done.

+            @Override
+            public long getCurrentTime() {
+                return sCurrentTime;
+            }
+        };
+        ShadowPlatformNetworksManager.sAllVisibleNetworks = new LinkedList<>(
+                Arrays.asList(FIRST_ALL_VISIBLE_NETWORKS, SECOND_ALL_VISIBLE_NETWORKS));
+        ShadowPlatformNetworksManager.sOnlyConnectedNetworks = new LinkedList<>(
+                Arrays.asList(FIRST_ONLY_CONNECTED_NETWORKS, SECOND_ONLY_CONNECTED_NETWORKS));
+
+        // Make sure that the cache is empty before every test.
+        VisibleNetworksTracker.clearCache();
+    }
+
+    @Test
+    public void testGetLastKnownVisibleNetworks_emptyCache() {
+        // Cache is empty before the getLastKnownVisibleNetworks call. The visibleNetworks
+        // are computed only for the connected wifi and cell and then cached.
+        VisibleNetworks visibleNetworks =
+                VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+        assertEquals(
+                FIRST_ONLY_CONNECTED_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testGetLastKnownVisibleNetworks_withValidCache() {
+        VisibleNetworks visibleNetworks =
+                VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+
+        // Time to consider the first cached networks still as valid.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_UNDER_THRESHOLD_TIME_MS;
+        visibleNetworks = VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+        assertEquals(
+                FIRST_ONLY_CONNECTED_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testGetLastKnownVisibleNetworks_withOldCache() {
+        VisibleNetworks visibleNetworks =
+                VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+
+        // Time to consider the first cached networks as invalid. Should fetch the second ones.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS;
+        visibleNetworks = VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+
+        assertEquals(SECOND_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+        assertEquals(
+                SECOND_ONLY_CONNECTED_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS,
+                VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testRefreshVisibleNetworks_emptyCache() {
+        // Cache is empty before the refreshVisibleNetworks call. The visibleNetworks are
+        // computed including all the visible cells and wifis then cached.
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+
+        assertEquals(FIRST_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testRefreshVisibleNetworks_validCacheOnlyConnected() {
+        VisibleNetworks visibleNetworks =
+                VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+
+        // Time to consider the first cached networks still as valid, refresh should be a noop.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_UNDER_THRESHOLD_TIME_MS;
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+
+        assertEquals(
+                FIRST_ONLY_CONNECTED_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testRefreshVisibleNetworks_validCacheAllVisible() {
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+        assertEquals(FIRST_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+
+        // Time to consider the first cached networks still as valid, refresh should be a noop.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_UNDER_THRESHOLD_TIME_MS;
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+
+        assertEquals(FIRST_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testRefreshVisibleNetworks_oldCacheOnlyConnected() {
+        VisibleNetworks visibleNetworks =
+                VisibleNetworksTracker.getLastKnownVisibleNetworks(sContext);
+        assertEquals(FIRST_ONLY_CONNECTED_NETWORKS, visibleNetworks);
+
+        // Time to consider the first cached networks as invalid. Should fetch the second ones.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS;
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+
+        assertEquals(FIRST_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS,
+                VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    @Test
+    public void testRefreshVisibleNetworks_oldCacheAllVisible() {
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+        assertEquals(FIRST_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS, VisibleNetworksTracker.getCachedVisibleNetworksTime());
+
+        // Time to consider the first cached networks as invalid. Should fetch the second ones.
+        sCurrentTime = CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS;
+        VisibleNetworksTracker.refreshVisibleNetworks(sContext);
+
+        assertEquals(
+                SECOND_ALL_VISIBLE_NETWORKS, VisibleNetworksTracker.getCachedVisibleNetworks());
+        assertEquals(CURRENT_TIME_MS + ELAPSED_OVER_THRESHOLD_TIME_MS,
+                VisibleNetworksTracker.getCachedVisibleNetworksTime());
+    }
+
+    /**
+     * Shadow PlatformNetworksManager for robolectric tests.
+     */
+    @Implements(PlatformNetworksManager.class)
+    public static class ShadowPlatformNetworksManager {
+        private static List<VisibleNetworks> sAllVisibleNetworks;
+        private static List<VisibleNetworks> sOnlyConnectedNetworks;
+
+        @Implementation
+        public static VisibleNetworks computeVisibleNetworks(
+                Context context, boolean includeAllVisibleNotConnectedNetworks) {
+            return includeAllVisibleNotConnectedNetworks ? sAllVisibleNetworks.remove(0)
+                                                         : sOnlyConnectedNetworks.remove(0);
+        }
+    }
+}