Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)
Patch Set: Restore earlier approach + UpdateDistribution() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
index ad1b727e0702f82e8f5f18dfdf36a2858c921183..05d15dfb03dadee11be190f5f4a92b5cdc472602 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
@@ -29,8 +29,10 @@ inline RemoteFrame::RemoteFrame(RemoteFrameClient* client,
Page& page,
FrameOwner* owner)
: Frame(client, page, owner, RemoteWindowProxyManager::Create(*this)),
- security_context_(RemoteSecurityContext::Create()) {
+ security_context_(RemoteSecurityContext::Create()),
+ last_inert_state_(false) {
dom_window_ = RemoteDOMWindow::Create(*this);
+ UpdateInertIfPossible();
}
RemoteFrame* RemoteFrame::Create(RemoteFrameClient* client,
@@ -121,6 +123,12 @@ bool RemoteFrame::ShouldClose() {
return true;
}
+void RemoteFrame::SetIsInert(bool inert) {
+ if (inert != last_inert_state_)
+ Client()->SetIsInert(inert);
+ last_inert_state_ = inert;
+}
+
void RemoteFrame::SetView(RemoteFrameView* view) {
// Oilpan: as RemoteFrameView performs no finalization actions,
// no explicit Dispose() of it needed here. (cf. LocalFrameView::Dispose().)

Powered by Google App Engine
This is Rietveld 408576698