Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)
Patch Set: Set Frame's inert bit on style calculation Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index d29aea93f4fc45ca49f5bbc9166070b8e65e7dbd..9bf5b3e8be040566c7c245d383be6258ba8f0ddf 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -124,6 +124,10 @@ class CORE_EXPORT LocalFrame final : public Frame,
void PrintNavigationWarning(const String&) override;
bool PrepareForCommit() override;
void DidChangeVisibilityState() override;
+ // This sets the is_inert_ flag and also recurses through this frame's
+ // subtree, updating the inert bit on all descendant frames.
+ void SetIsInert(bool) override;
+ bool IsInert() const override { return is_inert_; }
void DetachChildren();
void DocumentAttached();
@@ -274,6 +278,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
bool CanNavigateWithoutFramebusting(const Frame&, String& error_reason);
+ void PropagateInertToChildFrames();
+
std::unique_ptr<WebFrameScheduler> frame_scheduler_;
mutable FrameLoader loader_;
@@ -300,6 +306,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
bool in_view_source_mode_;
+ bool is_inert_;
+
Member<CoreProbeSink> probe_sink_;
Member<PerformanceMonitor> performance_monitor_;

Powered by Google App Engine
This is Rietveld 408576698