Propagate inert state to OOPIFs when a modal dialog is active

content/browser/frame_host/render_widget_host_view_child_frame.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 365 matching lines @@
   }
 }
 
 void RenderWidgetHostViewChildFrame::UpdateViewportIntersection(
     const gfx::Rect& viewport_intersection) {
   if (host_)
     host_->Send(new ViewMsg_SetViewportIntersection(host_->GetRoutingID(),
                                                     viewport_intersection));
 }
 
+void RenderWidgetHostViewChildFrame::SetIsInert() {
+  if (host_ && frame_connector_) {
+    host_->Send(new ViewMsg_SetIsInert(host_->GetRoutingID(),
+                                       frame_connector_->is_inert()));
+  }
+}
+
 void RenderWidgetHostViewChildFrame::GestureEventAck(
     const blink::WebGestureEvent& event,
     InputEventAckState ack_result) {
   bool not_consumed = ack_result == INPUT_EVENT_ACK_STATE_NOT_CONSUMED ||
                       ack_result == INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS;
   // GestureScrollBegin is consumed by the target frame and not forwarded,
   // because we don't know whether we will need to bubble scroll until we
   // receive a GestureScrollUpdate ACK. GestureScrollUpdate with unused
   // scroll extent is forwarded for bubbling, while GestureScrollEnd is
   // always forwarded and handled according to current scroll state in the
@@ skipping 217 matching lines @@
   return frame_connector_->TransformPointToCoordSpaceForView(
       point, target_view, cc::SurfaceId(frame_sink_id_, local_surface_id_),
       transformed_point);
 }
 
 bool RenderWidgetHostViewChildFrame::IsRenderWidgetHostViewChildFrame() {
   return true;
 }
 
 void RenderWidgetHostViewChildFrame::WillSendScreenRects() {
-  if (frame_connector_)
+  if (frame_connector_) {
     UpdateViewportIntersection(frame_connector_->viewport_intersection());
+    SetIsInert();

[alexmos, 2017/06/20 18:46:10]

Assuming that this handles the new process case, it seems like this will send
the inert IPC more often than necessary (every time there's a screen rects
update) - or maybe there's another reason why that's needed here and not
somewhere like Init()?  See also my earlier question about whether this will
work for cases like a(b(b)) and the bottom child navigating to a new process.

[kenrb, 2017/06/22 15:33:35]

I agree this doesn't feel like the greatest place, but I don't see a better one
for either SetIsInert or UpdateViewportIntersection, which need to trigger at a
certain point after cross-process navigations (this is covering a(b) -> a(c)
navigation scenario). RWHVCF::Init() is too early in terms of renderer state.
This will send the IPC unnecessarily, sometimes, but it doesn't get called very
often so it shouldn't be too bad. There are definitely some improvements that
can be made to RWHVCF initialization, so this might be re-thought when we get
around to dealing with subframe vs top-level frame resizing (bug 618353).

As mentioned in the other response, a(b(b)) -> a(b(c)) is covered by Blink
initializing the RemoteFrame.

[alexmos, 2017/06/22 17:09:27]

OK.  Perhaps add a TODO and describe some of those concerns here?

+  }
 }
 
 #if defined(OS_MACOSX)
 ui::AcceleratedWidgetMac*
 RenderWidgetHostViewChildFrame::GetAcceleratedWidgetMac() const {
   return nullptr;
 }
 
 void RenderWidgetHostViewChildFrame::SetActive(bool active) {
 }
@@ skipping 209 matching lines @@
     auto origin = GetViewBounds().origin() -
                   frame_connector_->GetRootRenderWidgetHostView()
                       ->GetViewBounds()
                       .origin();
     return gfx::Point(origin.x(), origin.y());
   }
   return gfx::Point();
 }
 
 }  // namespace content