Propagate inert state to OOPIFs when a modal dialog is active

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 2166 matching lines @@
 
   resolver.ClearStyleSharingList();
 
   DCHECK(!NeedsStyleRecalc());
   DCHECK(!ChildNeedsStyleRecalc());
   DCHECK(!NeedsReattachLayoutTree());
   DCHECK(!ChildNeedsReattachLayoutTree());
   DCHECK(InStyleRecalc());
   DCHECK_EQ(GetStyleResolver(), &resolver);
   lifecycle_.AdvanceTo(DocumentLifecycle::kStyleClean);
+
   if (should_record_stats) {
     TRACE_EVENT_END2(
         "blink,blink_style", "Document::updateStyle", "resolverAccessCount",
         GetStyleEngine().StyleForElementCount() - initial_element_count,
         "counters", GetStyleEngine().Stats()->ToTracedValue());
   } else {
     TRACE_EVENT_END1(
         "blink,blink_style", "Document::updateStyle", "resolverAccessCount",
         GetStyleEngine().StyleForElementCount() - initial_element_count);
   }
@@ skipping 56 matching lines @@
 
   ScriptForbiddenScope forbid_script;
 
   LocalFrameView* frame_view = View();
   if (frame_view && frame_view->IsInPerformLayout()) {
     // View layout should not be re-entrant.
     NOTREACHED();
     return;
   }
 
-  if (HTMLFrameOwnerElement* owner = LocalOwner())
+  HTMLFrameOwnerElement* owner = LocalOwner();
+  if (owner)
     owner->GetDocument().UpdateStyleAndLayout();
 
   UpdateStyleAndLayoutTree();
 
+  if (owner)
+    GetFrame()->SetIsInert(owner->IsInert());

[tkent, 2017/06/08 23:53:48]

This was added to fix "!node.NeedsDistributionRecalc()" dcheck failures, right?
I'm not sure if this is a right fix.
hayato@, do you have any advice?

[kenrb, 2017/06/09 15:15:48]

Correct, and I'm not sure it is the right fix either. My earlier attempts were
to update the cached inert values on the Frames whenever an inert attribute
changed, or else when a Frame was attached to its parent element. There were
DCHECKs hit because I was breaking assumptions about elements being style clean.
Re-checking a Frame's inertness during style update, which I added here, seems
to work, but I would welcome better suggestions on how to do it.

[hayato, 2017/06/13 09:48:00]

Using UpdateStyleAndLayout() as a hook for SetIsInert() doesn't look good to me.
What we have to do is calling UpdateDistribution() somewhere so that it doesn't
hit DCHCEK() before calling SetIsInert(), I think.

+
   if (!IsActive())
     return;
 
   if (frame_view->NeedsLayout())
     frame_view->UpdateLayout();
 
   if (Lifecycle().GetState() < DocumentLifecycle::kLayoutClean)
     Lifecycle().AdvanceTo(DocumentLifecycle::kLayoutClean);
 
   if (LocalFrameView* frame_view = View())
@@ skipping 4565 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->Url().GetString().Utf8().data());
 }
 #endif