Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2882973002: [coverage] Block coverage with support for IfStatements (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/mjsunit/code-coverage-block.js ('K') | « test/mjsunit/code-coverage-block.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
index a9307fbed07de575e73b38d6936f0fa6bc5c729d..036af600c67df4a748c040ca64f3e013fc1038ca 100644
--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
@@ -371,6 +371,13 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
builder.Debugger();
}
+ // Emit block counter increments.
+ {
+ SaveFlags save_flags;
+ FLAG_block_coverage = true; // Satisfy DCHECKs.
Michael Starzinger 2017/06/06 11:49:32 suggestion: We could also just remove the DCHECKs
rmcilroy 2017/06/06 13:02:32 +1
jgruber 2017/06/06 14:52:46 Done.
+ builder.IncBlockCounter(0);
+ }
+
// Bind labels for long jumps at the very end.
for (size_t i = 0; i < arraysize(end); i++) {
builder.Bind(&end[i]);
« test/mjsunit/code-coverage-block.js ('K') | « test/mjsunit/code-coverage-block.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698