Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/compiler.cc

Issue 2882973002: [coverage] Block coverage with support for IfStatements (Closed)
Patch Set: Remove coverage infos Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index a6cbe661e23374f80ad0f7e422a5670a58c9707c..773828611a5650a489f3ca59fd617417990e16cf 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -457,10 +457,16 @@ CompilationJob::Status FinalizeUnoptimizedCompilationJob(CompilationJob* job) {
CompilationJob::Status status = job->FinalizeJob();
if (status == CompilationJob::SUCCEEDED) {
CompilationInfo* info = job->info();
+ Isolate* isolate = info->isolate();
EnsureFeedbackMetadata(info);
+ if (info->has_coverage_info()) {
+ DCHECK(info->is_block_coverage_enabled());
+ isolate->debug()->InstallCoverageInfo(info->shared_info(),
+ info->coverage_info());
+ }
rmcilroy 2017/06/01 14:01:50 nit - maybe do this in InstallUnoptimizedCode simi
jgruber 2017/06/02 06:39:27 Done.
DCHECK(!info->code().is_null());
if (info->parse_info()->literal()->should_be_used_once_hint()) {
- info->code()->MarkToBeExecutedOnce(info->isolate());
+ info->code()->MarkToBeExecutedOnce(isolate);
}
InstallUnoptimizedCode(info);
RecordFunctionCompilation(CodeEventListener::FUNCTION_TAG, info);

Powered by Google App Engine
This is Rietveld 408576698