Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2882953003: Make another type inference test pass. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make another type inference test pass. Type inference for this test was already working; it just needed an expectation file and a main function. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a4bdc5cb4ee6cfd56f474f6bd6fdae546c39e50c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_function_typed_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_function_typed_param.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-15 16:38:05 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-15 16:41:24 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-15 17:00:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4bdc5cb4ee6cfd56f474f6bd6fdae546c39e50c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698