libvpx.gyp : issues fix for webview.

libvpx.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'libvpx_build_vp9%': 1,
     'libvpx_source%': 'source/libvpx',
     'conditions': [
       ['os_posix==1', {
         'asm_obj_extension': 'o',
@@ skipping 35 matching lines @@
   },
   'target_defaults': {
     'target_conditions': [
       ['<(libvpx_build_vp9)==0', {
         'sources/': [ ['exclude', '(^|/)vp9/'], ],
       }],
     ],
     'variables': {
       'conditions': [
         ['OS=="win" and buildtype=="Official"', {
-          # Do not set to 'size', as it results in an error on win64. 
+          # Do not set to 'size', as it results in an error on win64.
           'optimize' :'speed',
         }],
       ],
     },
   },
   'conditions': [
     ['target_arch=="ia32"', {
       'includes': ['libvpx_srcs_x86_intrinsics.gypi', ],
     }],
     ['target_arch=="x64" and msan==0', {
@@ skipping 210 matching lines @@
             },
             'ads2gas_script%': '<(ads2gas_script)',
             # Location of the assembly conversion script.
             'ads2gas_script_path': '<(libvpx_source)/build/make/<(ads2gas_script)',
             'ads2gas_script_include': '<(libvpx_source)/build/make/thumb.pm',
           },
           # We need to explicitly tell the assembler to look for
           # .include directive files from the place where they're
           # generated to.
           'cflags': [
-             '-Wa,-I,<!(pwd)/source/config/<(OS_CATEGORY)/<(target_arch_full)',
-             '-Wa,-I,<!(pwd)/source/config',
              '-Wa,-I,<(shared_generated_dir)',
           ],
           'xcode_settings': {
             'OTHER_CFLAGS': [
               '-I<!(pwd)/source/config/<(OS_CATEGORY)/<(target_arch_full)',
               '-I<!(pwd)/source/config',
               '-I<(shared_generated_dir)',
             ],
           },
           'include_dirs': [
@@ skipping 47 matching lines @@
               ],
             }],
             ['OS == "ios"', {
               'xcode_settings': {
                 'OTHER_CFLAGS!': [
                   # Breaks at least boolhuff_armv5te:token_high_bit_not_set_ev.
                   '-fstack-protector-all',  # Implies -fstack-protector
                 ],
               },
             }],
+            # .include directive files from the place where they're
+            # generated to, but they aren't used in android webview and
+            # generate the absolute path which isn't allowed in Android make
+            # file.
+            ['android_webview_build!=1', {
+              'cflags': [

[Johann, 2014/05/16 04:15:58]

would prefer to keep the chunks that modify cflags together. This could be moved
up or the other directive could be moved down.

# Add include paths for assembler:
cflags[...]
# For android webview, the following paths are not required and not allowed:
webview!=1[...]

I believe the reason for some of these paths were os x clang searched
differently than other versions we were using. But this isn't under
xcode_settings so I may be misremembering.

[michaelbai, 2014/05/16 18:09:00]

xcode_settings has same setting in line 291,  and
Do you know why the path leads with comma?


On 2014/05/16 04:15:58, Johann wrote:

[Johann, 2014/05/16 18:25:31]

All the more reason to keep these modification close to each other
the , trailing -Wa and -I? I do not know what that means.

[michaelbai, 2014/05/16 19:57:31]

Put them together


On 2014/05/16 18:25:31, Johann wrote:

[Torne, 2014/05/19 09:02:09]

-Wa is the gcc option for passing arguments to the assembler. The commas
separate the different arguments to pass to the assembler, so that it can tell
the difference between you wanting to pass N assembler arguments from you
wanting to pass, say, N-1 assembler arguments and 1 other gcc argument. So,
-Wa,-I,foo means "pass the arguments -I and foo to the assembler". Without the
commas gcc would attempt to interpret the -I and foo args itself.

+                '-Wa,-I,<!(pwd)/source/config/<(OS_CATEGORY)/<(target_arch_full)',
+                '-Wa,-I,<!(pwd)/source/config',
+              ],
+            }],
           ],
         },
       ],
     }],
   ],
   'targets': [
     {
       # A tool that runs on host to extract integers from object file.
       'target_name': 'libvpx_obj_int_extract',
       'type': 'executable',
@@ skipping 84 matching lines @@
         'libvpx_obj_int_extract#host',
       ],
       'variables' : {
         'lib_intermediate_name' : '',
         'output_format':'',
         'output_dir': '<(shared_generated_dir)',
         'conditions' : [
           ['android_webview_build==1', {
             # pass the empty string for 3rd and 4th arguments of
             # intermediates-dir-for macro.
-            'lib_intermediate_name' : '$(realpath $(call intermediates-dir-for, STATIC_LIBRARIES, libvpx_asm_offsets_vp8,,, $(GYP_VAR_PREFIX)))/libvpx_asm_offsets_vp8.a',
+            'lib_intermediate_name' : '$(abspath $(call intermediates-dir-for,STATIC_LIBRARIES,libvpx_asm_offsets_vp8,,,$(gyp_var_prefix)))/libvpx_asm_offsets_vp8.a',
           }],
           ['(target_arch=="arm" or target_arch=="armv7")', {
             'output_format': 'gas',
           }, {
             'output_format': 'rvds',
           }],
         ],
       },
       'conditions': [
         ['OS=="win"', {
@@ skipping 52 matching lines @@
         'libvpx_obj_int_extract#host',
       ],
       'variables' : {
         'lib_intermediate_name' : '',
         'output_format':'',
         'output_dir': '<(shared_generated_dir)',
         'conditions' : [
           ['android_webview_build==1', {
             # pass the empty string for 3rd and 4th arguments of
             # intermediates-dir-for macro.
-            'lib_intermediate_name' : '<(android_src)/$(call intermediates-dir-for, STATIC_LIBRARIES, libvpx_asm_offsets_vpx_scale,,, $(GYP_VAR_PREFIX))/libvpx_asm_offsets_vpx_scale.a',
+            'lib_intermediate_name' : '$(abspath $(call intermediates-dir-for,STATIC_LIBRARIES,libvpx_asm_offsets_vpx_scale,,,$(gyp_var_prefix)))/libvpx_asm_offsets_vpx_scale.a',
           }],
           ['(target_arch=="arm" or target_arch=="armv7")', {
             'output_format': 'gas',
           }, {
             'output_format': 'rvds',
           }],
         ],
       },
       'conditions': [
         ['OS=="win"', {
@@ skipping 34 matching lines @@
          # Need this otherwise gyp won't run the rule on them.
           'sources': [
             '<(INTERMEDIATE_DIR)/vpx_scale_asm_offsets.o',
           ],
         }],
       ],
       'includes': ['obj_int_extract.gypi'],
     },
   ],
 }