Store Typedef(s) in kernel when parsing with Fasta, deserilize in DillLibraryBuilder.

Store Typedef(s) in kernel when parsing with Fasta, deserilize in DillLibraryBuilder.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/dd62ad5d7781fa1097d20f8a0ca4c9ec87ab03d7

[Paul Berry, 2017-05-14 22:30:38]

lgtm

https://codereview.chromium.org/2882893002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart
(right):

https://codereview.chromium.org/2882893002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart:52:
var typedef = new Typedef(name, type);
Can we rename this variable to avoid confusion with the built-in identifier
"typedef"?  It looks weird in the code review.

(FWIW, I've been adopting the convention used in several places in kernel, which
is to add a trailing underscore, so this would become "typedef_").

[scheglov, 2017-05-14 22:41:58]

https://codereview.chromium.org/2882893002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart
(right):

https://codereview.chromium.org/2882893002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart:52:
var typedef = new Typedef(name, type);
On 2017/05/14 22:30:38, Paul Berry wrote:
> Can we rename this variable to avoid confusion with the built-in identifier
> "typedef"?  It looks weird in the code review.
> 
> (FWIW, I've been adopting the convention used in several places in kernel,
which
> is to add a trailing underscore, so this would become "typedef_").

Done.

[scheglov, 2017-05-15 00:52:04]

Description was changed from

==========
Store Typedef(s) in kernel when parsing with Fasta, deserilize in
DillLibraryBuilder.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Store Typedef(s) in kernel when parsing with Fasta, deserilize in
DillLibraryBuilder.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/dd62ad5d7781fa1097d20f8a0ca4c9ec87ab03d7
==========

[scheglov, 2017-05-15 00:52:06]

Committed patchset #2 (id:20001) manually as
dd62ad5d7781fa1097d20f8a0ca4c9ec87ab03d7 (presubmit successful).