Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2882863002: Implement full closure inference logic. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -33 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 6 chunks +134 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 4 chunks +0 lines, -16 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/async_closure_return_type_future.dart.strong.expect View 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_nested_lambdas.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_field.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_field.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_top_level.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_top_level.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_dynamic_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_type_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_type_param.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_no_type_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_no_type_param.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_dynamic.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_typed.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_untyped.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_no_type_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_no_type_param.dart.strong.expect View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-14 15:20:17 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-14 17:58:07 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-14 22:21:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
66a8d2ec9ccf13e2edead13d92229810dd788b5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698