Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 288263003: Adding more browser tests in copy between windows in file manager. (Closed)

Created:
6 years, 7 months ago by tturchetto1
Modified:
6 years, 7 months ago
Reviewers:
hirono, satorux1, satorux
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Adding more browser tests in copy between windows in file manager. BUG=375853 TEST=This is test. Ran tests manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271954

Patch Set 1 #

Total comments: 2

Patch Set 2 : Modification based on previous CL review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/copy_between_windows.js View 2 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hirono
lgtm with a nit. Thank you! https://codereview.chromium.org/288263003/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/288263003/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode873 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:873: TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToLocal"), nit: ...
6 years, 7 months ago (2014-05-19 04:22:48 UTC) #1
tturchetto1
https://codereview.chromium.org/288263003/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/288263003/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode873 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:873: TestParameter(NOT_IN_GUEST_MODE, "copyBetweenWindowsDriveToLocal"), On 2014/05/19 04:22:49, hirono wrote: > nit: ...
6 years, 7 months ago (2014-05-19 20:15:45 UTC) #2
tturchetto1
The CQ bit was checked by tturchetto@google.com
6 years, 7 months ago (2014-05-19 20:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tturchetto@google.com/288263003/20001
6 years, 7 months ago (2014-05-19 20:17:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 00:08:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 00:13:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68521)
6 years, 7 months ago (2014-05-20 00:13:21 UTC) #7
satorux1
LGTM based on hirono's. BUG=None is unusual. tturchetto@, could you file a bug and update ...
6 years, 7 months ago (2014-05-21 17:57:20 UTC) #8
tturchetto1
The CQ bit was checked by tturchetto@google.com
6 years, 7 months ago (2014-05-21 18:55:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tturchetto@google.com/288263003/20001
6 years, 7 months ago (2014-05-21 19:56:42 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:15:41 UTC) #11
Message was sent while issue was closed.
Change committed as 271954

Powered by Google App Engine
This is Rietveld 408576698