Source/core/rendering/RenderMultiColumnSet.h - Issue 288263002: [New Multicolumn] Rebalance properly when child content changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSet.h

Issue 288263002: [New Multicolumn] Rebalance properly when child content changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderMultiColumnFlowThread.cpp ('K') | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | Source/core/rendering/RenderMultiColumnSet.cpp » ('j') | Source/core/rendering/RenderMultiColumnSet.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSet.h

diff --git a/Source/core/rendering/RenderMultiColumnSet.h b/Source/core/rendering/RenderMultiColumnSet.h

index 7caab518bc65064dff8654b7266dfccc25264db1..d7e7e3dea4044d36f3157df894fdff13220b84e5 100644

--- a/Source/core/rendering/RenderMultiColumnSet.h

+++ b/Source/core/rendering/RenderMultiColumnSet.h

@@ -108,7 +108,7 @@ public:

virtual void updateLogicalWidth() OVERRIDE;

- void prepareForLayout();

+ void prepareForLayout(bool initial);

// Expand this set's flow thread portion rectangle to contain all trailing flow thread

// overflow. Only to be called on the last set.

@@ -137,6 +137,7 @@ private:

void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset);

+ LayoutUnit calculateMaxColumnHeight() const;

LayoutUnit columnGap() const;

LayoutRect columnRectAt(unsigned index) const;

unsigned columnCount() const;